From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 4E6CEE00873; Mon, 2 Mar 2015 05:04:32 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mail.free-electrons.com (down.free-electrons.com [37.187.137.238]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 772F1E0086D for ; Mon, 2 Mar 2015 05:04:28 -0800 (PST) Received: by mail.free-electrons.com (Postfix, from userid 106) id 7B6DA497; Mon, 2 Mar 2015 14:04:28 +0100 (CET) Received: from localhost (128-79-216-6.hfc.dyn.abo.bbox.fr [128.79.216.6]) by mail.free-electrons.com (Postfix) with ESMTPSA id 48B001AA; Mon, 2 Mar 2015 14:04:28 +0100 (CET) Date: Mon, 2 Mar 2015 14:04:26 +0100 From: Alexandre Belloni To: Otavio Salvador Message-ID: <20150302130426.GN4094@piout.net> References: <1425296733-32438-1-git-send-email-alexandre.belloni@free-electrons.com> <1425296733-32438-2-git-send-email-alexandre.belloni@free-electrons.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Cc: "meta-freescale@yoctoproject.org" Subject: Re: [meta-fsl-arm][PATCH 2/2] machines: Add IMAGE_BOOT_FILES X-BeenThere: meta-freescale@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-fsl-* layers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Mar 2015 13:04:32 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On 02/03/2015 at 09:35:36 -0300, Otavio Salvador wrote : > On Mon, Mar 2, 2015 at 8:45 AM, Alexandre Belloni > wrote: > > Define IMAGE_BOOT_FILES in the machine configuration to be able to > > create sdcard images using wic. > > > > Signed-off-by: Alexandre Belloni > > Thanks for looking at this; wic is indeed a very handy addition :-) > > > diff --git a/conf/machine/imx51evk.conf b/conf/machine/imx51evk.conf > > index 9d7d06ca41fc..89bcacb932fb 100644 > > --- a/conf/machine/imx51evk.conf > > +++ b/conf/machine/imx51evk.conf > > @@ -13,5 +13,6 @@ SOC_FAMILY = "mx5:mx51" > > PERF_FEATURES_ENABLE = "" > > > > KERNEL_DEVICETREE = "imx51-babbage.dtb" > > +IMAGE_BOOT_FILES = "zImage zImage-imx51-babbage.dtb;imx51-babbage.dtb" > > > > UBOOT_MACHINE = "mx51evk_config" > > To be honest, I don't like the idea of maintaining the list of > duplicated device tree files. > > I am wondering if we can cook a generic solution whick uses > KERNEL_DEVICETREE as input and generates the list of artifacts it > needs to install. Leaving them disconnected is very error prone. > I agree but that is the current mechanism. Actually, I think we should even have a better mechanism were it would be possible to select which files are going to which partition. I didn't implement it yet. There is one issue with generating the IMAGE_BOOT_FILES from KERNEL_DEVICETREE. You can put non existing dtb filenames in KERNEL_DEVICETREE and they will be ignored but not in IMAGE_BOOT_FILES. That is the case for imx6qsabresd.conf. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com