From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH v6 04/23] libxc: duplicate snippet to
 allocate p2m_host array
Date: Mon, 2 Mar 2015 11:46:33 -0500
Message-ID: <20150302164633.GM3418@l.oracle.com>
References: <1424966166-2388-1-git-send-email-wei.liu2@citrix.com>
	<1424966166-2388-5-git-send-email-wei.liu2@citrix.com>
	<1425310018.21151.84.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <1425310018.21151.84.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>, Wei Liu <wei.liu2@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

> > @@ -772,15 +772,16 @@ int arch_setup_meminit(struct xc_dom_image *dom)
> >              return rc;
> >      }
> >  
> > -    dom->p2m_host = xc_dom_malloc(dom, sizeof(xen_pfn_t) * dom->total_pages);
> > -    if ( dom->p2m_host == NULL )
> > -        return -EINVAL;
> > -
> >      if ( dom->superpages )
> >      {
> >          int count = dom->total_pages >> SUPERPAGE_PFN_SHIFT;
> >          xen_pfn_t extents[count];
> >  
> > +        dom->p2m_host = xc_dom_malloc(dom, sizeof(xen_pfn_t) *
> > +                                      dom->total_pages);

'count' pls.

> > +        if ( dom->p2m_host == NULL )
> > +            return -EINVAL;
> > +
> >          DOMPRINTF("Populating memory with %d superpages", count);
> >          for ( pfn = 0; pfn < count; pfn++ )
> >              extents[pfn] = pfn << SUPERPAGE_PFN_SHIFT;
> > @@ -809,9 +810,13 @@ int arch_setup_meminit(struct xc_dom_image *dom)
> >                  return rc;
> >          }
> >          /* setup initial p2m */
> > +        dom->p2m_host = xc_dom_malloc(dom, sizeof(xen_pfn_t) *
> > +                                      dom->total_pages);
> > +        if ( dom->p2m_host == NULL )
> > +            return -EINVAL;
> >          for ( pfn = 0; pfn < dom->total_pages; pfn++ )
> >              dom->p2m_host[pfn] = pfn;
> > -        
> > +

??
> >          /* allocate guest memory */
> >          for ( i = rc = allocsz = 0;
> >                (i < dom->total_pages) && !rc;
> 
>