All of lore.kernel.org
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, info@crazy-audio.com,
	lgirdwood@gmail.com, patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH 1/2] ASoC: wm8804: Fix small issues in probe error path
Date: Mon, 2 Mar 2015 18:15:56 +0000	[thread overview]
Message-ID: <20150302181556.GD2042@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20150302180351.GA21293@sirena.org.uk>

On Mon, Mar 02, 2015 at 06:03:51PM +0000, Mark Brown wrote:
> On Mon, Mar 02, 2015 at 05:57:54PM +0000, Charles Keepax wrote:
> 
> > The regulator notifiers were not being cleared up on the error path in
> > wm8804_probe and the nothing was being cleared up if
> > snd_soc_register_codec failed. This patch fixes these issues.
> 
> Why not fix this at source by adding a devm_ notifier registration?

Oops.. yeah that is almost certainly better. I will respin for
that.

Thanks,
Charles

      reply	other threads:[~2015-03-02 18:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-02 17:57 [PATCH 1/2] ASoC: wm8804: Fix small issues in probe error path Charles Keepax
2015-03-02 17:57 ` [PATCH 2/2] ASoC: wm8804: Add DAPM widgets for SPDIF/AIF Charles Keepax
2015-03-02 18:16   ` Mark Brown
2015-03-02 21:35     ` Charles Keepax
2015-03-02 18:03 ` [PATCH 1/2] ASoC: wm8804: Fix small issues in probe error path Mark Brown
2015-03-02 18:15   ` Charles Keepax [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150302181556.GD2042@opensource.wolfsonmicro.com \
    --to=ckeepax@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=info@crazy-audio.com \
    --cc=lgirdwood@gmail.com \
    --cc=patches@opensource.wolfsonmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.