All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Luis Claudio R. Goncalves" <lclaudio@uudg.org>
To: linux-rt-users@vger.kernel.org
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: [PATCH] rcutorture: fix missing function at build time
Date: Mon, 2 Mar 2015 17:15:31 -0300	[thread overview]
Message-ID: <20150302201530.GA4189@uudg.org> (raw)

Hello,

This is a minor issue, but as I seem to have woken up Paul at 4AM with the
many beeps from IRC I would feel bad if I did not send this patch to the
list. Actually, as that patch has been sitting on my computer for a few
days now, i already feel bad :)


rcutorture: fix missing function at build time

Trying to build the rcutorture module on 3.18.7-rt2 ends up on:

   ERROR: "rcu_force_quiescent_state" [kernel/rcu/rcutorture.ko] undefined!

Commit "71d22b5 Subject: rcu: Merge RCU-bh into RCU-preempt" encloses three
functions (rcu_batches_completed_bh, rcu_force_quiescent_state and
rcu_bh_force_quiescent_state) on an #ifndef CONFIG_PREEMPT_RT_FULL / #endif
pair, rendering them non-existent on RT. As the commit points out, that was
a wise and necessary move.

But in order to get rcutorture build working again we need to define an
empty rcu_force_quiescent_state function.

Signed-off-by: Luis Claudio R. Goncalves <lclaudio@uudg.org>

diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
index a4e9e25..28a54f6 100644
--- a/kernel/rcu/tree.c
+++ b/kernel/rcu/tree.c
@@ -378,6 +378,11 @@ void rcu_bh_force_quiescent_state(void)
 	force_quiescent_state(&rcu_bh_state);
 }
 EXPORT_SYMBOL_GPL(rcu_bh_force_quiescent_state);
+#else
+void rcu_force_quiescent_state(void)
+{
+}
+EXPORT_SYMBOL_GPL(rcu_force_quiescent_state);
 #endif
 
 /*

-- 
[ Luis Claudio R. Goncalves                    Bass - Gospel - RT ]
[ Fingerprint: 4FDD B8C4 3C59 34BD 8BE9  2696 7203 D980 A448 C8F8 ]


             reply	other threads:[~2015-03-02 20:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-02 20:15 Luis Claudio R. Goncalves [this message]
2015-03-02 21:18 ` [PATCH] rcutorture: fix missing function at build time Paul E. McKenney
2015-03-02 21:20   ` Luis Claudio R. Goncalves
2015-03-02 21:30     ` Paul E. McKenney
2015-03-06 18:32 ` Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150302201530.GA4189@uudg.org \
    --to=lclaudio@uudg.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.