All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: NeilBrown <neilb@suse.de>
Cc: Tony Lindgren <tony@atomide.com>, Felipe Balbi <balbi@ti.com>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	linux-omap@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>,
	GTA04 owners <gta04-owner@goldelico.com>
Subject: Re: [PATCH 1/4] usb: phy: twl4030: make runtime pm more reliable.
Date: Mon, 2 Mar 2015 22:03:59 +0100	[thread overview]
Message-ID: <20150302210359.GG13270@amd> (raw)
In-Reply-To: <20150224034036.31400.6133.stgit@notabene.brown>

Hi!

> +		status_changed =
> +			(twl->linkstat == OMAP_MUSB_VBUS_VALID ||
> +			 twl->linkstat == OMAP_MUSB_ID_GROUND)
> +			!=
> +			(status == OMAP_MUSB_VBUS_VALID ||
> +			 status == OMAP_MUSB_ID_GROUND);
>  		twl->linkstat = status;
...
> @@ -768,6 +770,10 @@ static int twl4030_usb_remove(struct platform_device *pdev)
>  
>  	/* disable complete OTG block */
>  	twl4030_usb_clear_bits(twl, POWER_CTRL, POWER_CTRL_OTG_ENAB);
> +
> +	if (twl->linkstat == OMAP_MUSB_VBUS_VALID ||
> +	    twl->linkstat == OMAP_MUSB_ID_GROUND)
> +		pm_runtime_put_noidle(twl->dev);
>  	pm_runtime_mark_last_busy(twl->dev);

inline function returning (x == OMAP_MUSB_VBUS_VALID || x ==
OMAP_MUSB_ID_GROUND) would really help readability here.

Thanks,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  parent reply	other threads:[~2015-03-02 21:03 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-24  3:40 [PATCH 0/4] Enhancements to twl4030 phy to support better charging NeilBrown
2015-02-24  3:40 ` NeilBrown
2015-02-24  3:40 ` [PATCH 2/4] usb: phy: twl4030: allow charger to see usb current draw limits NeilBrown
2015-02-24  3:40   ` NeilBrown
2015-03-02 21:03   ` Pavel Machek
2015-03-04  6:17     ` NeilBrown
2015-02-24  3:40 ` [PATCH 4/4] usb: phy: twl4030: test ID resistance to see if charger is present NeilBrown
2015-02-24  3:40   ` NeilBrown
2015-03-02 21:04   ` Pavel Machek
2015-03-04  6:40     ` NeilBrown
2015-02-24  3:40 ` [PATCH 3/4] usb: phy: twl4030: add support for reading restore on ID pin NeilBrown
2015-02-24  3:40   ` NeilBrown
2015-03-02 21:04   ` Pavel Machek
2015-03-04  6:35     ` NeilBrown
2015-03-04  6:54       ` [Gta04-owner] " Dr. H. Nikolaus Schaller
2015-03-22  6:05         ` NeilBrown
2015-03-04 10:17       ` Pavel Machek
2015-02-24  3:40 ` [PATCH 1/4] usb: phy: twl4030: make runtime pm more reliable NeilBrown
2015-02-24  3:40   ` NeilBrown
2015-02-24 20:44   ` Tony Lindgren
2015-03-02 21:03   ` Pavel Machek [this message]
2015-03-04  6:24     ` NeilBrown
2015-02-24 20:46 ` [PATCH 0/4] Enhancements to twl4030 phy to support better charging Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150302210359.GG13270@amd \
    --to=pavel@ucw.cz \
    --cc=balbi@ti.com \
    --cc=gta04-owner@goldelico.com \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.