From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 10/10] ARM: omap2: use clkdev_add_alias() Date: Mon, 2 Mar 2015 16:13:42 -0800 Message-ID: <20150303001341.GD3756@atomide.com> References: <20150302170538.GQ8656@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from pmta2.delivery1.ore.mailhop.org (pmta2.delivery1.ore.mailhop.org [54.149.155.156]) by alsa0.perex.cz (Postfix) with ESMTP id 2E1E6260676 for ; Tue, 3 Mar 2015 01:19:15 +0100 (CET) Received: from smtp5.ore.mailhop.org (172.31.36.112) by pmta2.delivery1.ore.mailhop.org id hujv1c20u50n for ; Tue, 3 Mar 2015 00:19:32 +0000 (envelope-from ) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Russell King Cc: linux-sh@vger.kernel.org, alsa-devel@alsa-project.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org List-Id: alsa-devel@alsa-project.org KiBSdXNzZWxsIEtpbmcgPHJtaytrZXJuZWxAYXJtLmxpbnV4Lm9yZy51az4gWzE1MDMwMiAwOTox MF06Cj4gV2hlbiBjcmVhdGluZyBhbGlhc2VzIG9mIGV4aXN0aW5nIGNsa2RldiBjbG9ja3MsIHVz ZSBjbGtkZXZfYWRkX2FsaWFzKCkKPiBpc250ZWFkIG9mIG9wZW4gY29kaW5nIHRoZSBsb29rdXAg YW5kIGNsa19sb29rdXAgY3JlYXRpb24uCgpHYXZlIHRoaXMgc2VyaWVzIGEgcXVpY2sgdHJ5IGJ1 dCBJIGdldCB0aGVzZSBidWlsZCBlcnJvcnM6CgphcmNoL2FybS9tYWNoLW9tYXAyL29tYXBfZGV2 aWNlLmM6IEluIGZ1bmN0aW9uIOKAmF9hZGRfY2xrZGV24oCZOgphcmNoL2FybS9tYWNoLW9tYXAy L29tYXBfZGV2aWNlLmM6NjU6NTg6IHdhcm5pbmc6IHBhc3NpbmcgYXJndW1lbnQgMyBvZiDigJhj bGtfYWRkX2FsaWFz4oCZIGRpc2NhcmRzIOKAmGNvbnN04oCZIHF1YWxpZmllciBmcm9tIHBvaW50 ZXIgdGFyZ2V0IHR5cGUKICByYyA9IGNsa19hZGRfYWxpYXMoY2xrX2FsaWFzLCBkZXZfbmFtZSgm b2QtPnBkZXYtPmRldiksIGNsa19uYW1lLCBOVUxMKTsKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIF4KSW4gZmlsZSBpbmNsdWRlZCBmcm9t IGFyY2gvYXJtL21hY2gtb21hcDIvb21hcF9kZXZpY2UuYzozNDowOgppbmNsdWRlL2xpbnV4L2Ns a2Rldi5oOjQ0OjU6IG5vdGU6IGV4cGVjdGVkIOKAmGNoYXIgKuKAmSBidXQgYXJndW1lbnQgaXMg b2YgdHlwZSDigJhjb25zdCBjaGFyICrigJkKIGludCBjbGtfYWRkX2FsaWFzKGNvbnN0IGNoYXIg KiwgY29uc3QgY2hhciAqLCBjaGFyICosIHN0cnVjdCBkZXZpY2UgKik7CiAgICAgXgpkcml2ZXJz L2Nsay9jbGtkZXYuYzoyOTg6MTY6IGVycm9yOiBleHBlY3RlZCBkZWNsYXJhdGlvbiBzcGVjaWZp ZXJzIG9yIOKAmC4uLuKAmSBiZWZvcmUg4oCYKOKAmSB0b2tlbgogdmNsa2Rldl9jcmVhdGUoKHN0 cnVjdCBjbGsgKmNsaywgY29uc3QgY2hhciAqY29uX2lkLCBjb25zdCBjaGFyICpkZXZfZm10LAog ICAgICAgICAgICAgICAgXgpkcml2ZXJzL2Nsay9jbGtkZXYuYzozMjI6OTI6IGVycm9yOiBzdG9y YWdlIGNsYXNzIHNwZWNpZmllZCBmb3IgcGFyYW1ldGVyIOKAmF9fY3JjX2Nsa2Rldl9hbGxvY+KA mQogRVhQT1JUX1NZTUJPTChjbGtkZXZfYWxsb2MpOwogICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIF4KZHJpdmVycy9jbGsvY2xrZGV2LmM6MzIyOjE6IHdhcm5pbmc6IOKAmHdlYWvi gJkgYXR0cmlidXRlIGlnbm9yZWQgWy1XYXR0cmlidXRlc10KIEVYUE9SVF9TWU1CT0woY2xrZGV2 X2FsbG9jKTsKIF4KZHJpdmVycy9jbGsvY2xrZGV2LmM6MzIyOjE6IHdhcm5pbmc6IOKAmGV4dGVy bmFsbHlfdmlzaWJsZeKAmSBhdHRyaWJ1dGUgaWdub3JlZCBbLVdhdHRyaWJ1dGVzXQpkcml2ZXJz L2Nsay9jbGtkZXYuYzozMjI6MTYxOiBlcnJvcjogc3RvcmFnZSBjbGFzcyBzcGVjaWZpZWQgZm9y IHBhcmFtZXRlciDigJhfX2tjcmN0YWJfY2xrZGV2X2FsbG9j4oCZCiBFWFBPUlRfU1lNQk9MKGNs a2Rldl9hbGxvYyk7CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgXgpkcml2ZXJzL2Nsay9jbGtkZXYuYzozMjI6MTogd2FybmluZzog4oCYX191c2VkX1/igJkg YXR0cmlidXRlIGlnbm9yZWQgWy1XYXR0cmlidXRlc10KIEVYUE9SVF9TWU1CT0woY2xrZGV2X2Fs bG9jKTsKIF4KZHJpdmVycy9jbGsvY2xrZGV2LmM6MzIyOjE2MTogZXJyb3I6IHNlY3Rpb24gYXR0 cmlidXRlIG5vdCBhbGxvd2VkIGZvciDigJhfX2tjcmN0YWJfY2xrZGV2X2FsbG9j4oCZCiBFWFBP UlRfU1lNQk9MKGNsa2Rldl9hbGxvYyk7CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgXgpkcml2ZXJzL2Nsay9jbGtkZXYuYzozMjI6Mjc5OiBlcnJvcjogZXhw ZWN0ZWQg4oCYO+KAmSwg4oCYLOKAmSBvciDigJgp4oCZIGJlZm9yZSDigJg94oCZIHRva2VuCiBF WFBPUlRfU1lNQk9MKGNsa2Rldl9hbGxvYyk7Cgpkcml2ZXJzL2Nsay9jbGtkZXYuYzoyNzQ6MTog d2FybmluZzog4oCYdmNsa2Rldl9hbGxvY+KAmSBkZWZpbmVkIGJ1dCBub3QgdXNlZCBbLVd1bnVz ZWQtZnVuY3Rpb25dCiB2Y2xrZGV2X2FsbG9jKHN0cnVjdCBjbGsgKmNsaywgY29uc3QgY2hhciAq Y29uX2lkLCBjb25zdCBjaGFyICpkZXZfZm10LAoKUmVnYXJkcywKClRvbnkKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KQWxzYS1kZXZlbCBtYWlsaW5nIGxp c3QKQWxzYS1kZXZlbEBhbHNhLXByb2plY3Qub3JnCmh0dHA6Ly9tYWlsbWFuLmFsc2EtcHJvamVj dC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbHNhLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Date: Tue, 03 Mar 2015 00:13:42 +0000 Subject: Re: [PATCH 10/10] ARM: omap2: use clkdev_add_alias() Message-Id: <20150303001341.GD3756@atomide.com> List-Id: References: <20150302170538.GQ8656@n2100.arm.linux.org.uk> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Russell King Cc: linux-sh@vger.kernel.org, alsa-devel@alsa-project.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org * Russell King [150302 09:10]: > When creating aliases of existing clkdev clocks, use clkdev_add_alias() > isntead of open coding the lookup and clk_lookup creation. Gave this series a quick try but I get these build errors: arch/arm/mach-omap2/omap_device.c: In function ‘_add_clkdev’: arch/arm/mach-omap2/omap_device.c:65:58: warning: passing argument 3 of ‘clk_add_alias’ discards ‘const’ qualifier from pointer target type rc = clk_add_alias(clk_alias, dev_name(&od->pdev->dev), clk_name, NULL); ^ In file included from arch/arm/mach-omap2/omap_device.c:34:0: include/linux/clkdev.h:44:5: note: expected ‘char *’ but argument is of type ‘const char *’ int clk_add_alias(const char *, const char *, char *, struct device *); ^ drivers/clk/clkdev.c:298:16: error: expected declaration specifiers or ‘...’ before ‘(’ token vclkdev_create((struct clk *clk, const char *con_id, const char *dev_fmt, ^ drivers/clk/clkdev.c:322:92: error: storage class specified for parameter ‘__crc_clkdev_alloc’ EXPORT_SYMBOL(clkdev_alloc); ^ drivers/clk/clkdev.c:322:1: warning: ‘weak’ attribute ignored [-Wattributes] EXPORT_SYMBOL(clkdev_alloc); ^ drivers/clk/clkdev.c:322:1: warning: ‘externally_visible’ attribute ignored [-Wattributes] drivers/clk/clkdev.c:322:161: error: storage class specified for parameter ‘__kcrctab_clkdev_alloc’ EXPORT_SYMBOL(clkdev_alloc); ^ drivers/clk/clkdev.c:322:1: warning: ‘__used__’ attribute ignored [-Wattributes] EXPORT_SYMBOL(clkdev_alloc); ^ drivers/clk/clkdev.c:322:161: error: section attribute not allowed for ‘__kcrctab_clkdev_alloc’ EXPORT_SYMBOL(clkdev_alloc); ^ drivers/clk/clkdev.c:322:279: error: expected ‘;’, ‘,’ or ‘)’ before ‘=’ token EXPORT_SYMBOL(clkdev_alloc); drivers/clk/clkdev.c:274:1: warning: ‘vclkdev_alloc’ defined but not used [-Wunused-function] vclkdev_alloc(struct clk *clk, const char *con_id, const char *dev_fmt, Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Mon, 2 Mar 2015 16:13:42 -0800 Subject: [PATCH 10/10] ARM: omap2: use clkdev_add_alias() In-Reply-To: References: <20150302170538.GQ8656@n2100.arm.linux.org.uk> Message-ID: <20150303001341.GD3756@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Russell King [150302 09:10]: > When creating aliases of existing clkdev clocks, use clkdev_add_alias() > isntead of open coding the lookup and clk_lookup creation. Gave this series a quick try but I get these build errors: arch/arm/mach-omap2/omap_device.c: In function ?_add_clkdev?: arch/arm/mach-omap2/omap_device.c:65:58: warning: passing argument 3 of ?clk_add_alias? discards ?const? qualifier from pointer target type rc = clk_add_alias(clk_alias, dev_name(&od->pdev->dev), clk_name, NULL); ^ In file included from arch/arm/mach-omap2/omap_device.c:34:0: include/linux/clkdev.h:44:5: note: expected ?char *? but argument is of type ?const char *? int clk_add_alias(const char *, const char *, char *, struct device *); ^ drivers/clk/clkdev.c:298:16: error: expected declaration specifiers or ?...? before ?(? token vclkdev_create((struct clk *clk, const char *con_id, const char *dev_fmt, ^ drivers/clk/clkdev.c:322:92: error: storage class specified for parameter ?__crc_clkdev_alloc? EXPORT_SYMBOL(clkdev_alloc); ^ drivers/clk/clkdev.c:322:1: warning: ?weak? attribute ignored [-Wattributes] EXPORT_SYMBOL(clkdev_alloc); ^ drivers/clk/clkdev.c:322:1: warning: ?externally_visible? attribute ignored [-Wattributes] drivers/clk/clkdev.c:322:161: error: storage class specified for parameter ?__kcrctab_clkdev_alloc? EXPORT_SYMBOL(clkdev_alloc); ^ drivers/clk/clkdev.c:322:1: warning: ?__used__? attribute ignored [-Wattributes] EXPORT_SYMBOL(clkdev_alloc); ^ drivers/clk/clkdev.c:322:161: error: section attribute not allowed for ?__kcrctab_clkdev_alloc? EXPORT_SYMBOL(clkdev_alloc); ^ drivers/clk/clkdev.c:322:279: error: expected ?;?, ?,? or ?)? before ?=? token EXPORT_SYMBOL(clkdev_alloc); drivers/clk/clkdev.c:274:1: warning: ?vclkdev_alloc? defined but not used [-Wunused-function] vclkdev_alloc(struct clk *clk, const char *con_id, const char *dev_fmt, Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from pmta2.delivery9.ore.mailhop.org ([54.148.30.215]:60782 "EHLO pmta2.delivery9.ore.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755479AbbCCBTT (ORCPT ); Mon, 2 Mar 2015 20:19:19 -0500 Date: Mon, 2 Mar 2015 16:13:42 -0800 From: Tony Lindgren To: Russell King Cc: alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-omap@vger.kernel.org, linux-sh@vger.kernel.org Subject: Re: [PATCH 10/10] ARM: omap2: use clkdev_add_alias() Message-ID: <20150303001341.GD3756@atomide.com> References: <20150302170538.GQ8656@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-media-owner@vger.kernel.org List-ID: * Russell King [150302 09:10]: > When creating aliases of existing clkdev clocks, use clkdev_add_alias() > isntead of open coding the lookup and clk_lookup creation. Gave this series a quick try but I get these build errors: arch/arm/mach-omap2/omap_device.c: In function ‘_add_clkdev’: arch/arm/mach-omap2/omap_device.c:65:58: warning: passing argument 3 of ‘clk_add_alias’ discards ‘const’ qualifier from pointer target type rc = clk_add_alias(clk_alias, dev_name(&od->pdev->dev), clk_name, NULL); ^ In file included from arch/arm/mach-omap2/omap_device.c:34:0: include/linux/clkdev.h:44:5: note: expected ‘char *’ but argument is of type ‘const char *’ int clk_add_alias(const char *, const char *, char *, struct device *); ^ drivers/clk/clkdev.c:298:16: error: expected declaration specifiers or ‘...’ before ‘(’ token vclkdev_create((struct clk *clk, const char *con_id, const char *dev_fmt, ^ drivers/clk/clkdev.c:322:92: error: storage class specified for parameter ‘__crc_clkdev_alloc’ EXPORT_SYMBOL(clkdev_alloc); ^ drivers/clk/clkdev.c:322:1: warning: ‘weak’ attribute ignored [-Wattributes] EXPORT_SYMBOL(clkdev_alloc); ^ drivers/clk/clkdev.c:322:1: warning: ‘externally_visible’ attribute ignored [-Wattributes] drivers/clk/clkdev.c:322:161: error: storage class specified for parameter ‘__kcrctab_clkdev_alloc’ EXPORT_SYMBOL(clkdev_alloc); ^ drivers/clk/clkdev.c:322:1: warning: ‘__used__’ attribute ignored [-Wattributes] EXPORT_SYMBOL(clkdev_alloc); ^ drivers/clk/clkdev.c:322:161: error: section attribute not allowed for ‘__kcrctab_clkdev_alloc’ EXPORT_SYMBOL(clkdev_alloc); ^ drivers/clk/clkdev.c:322:279: error: expected ‘;’, ‘,’ or ‘)’ before ‘=’ token EXPORT_SYMBOL(clkdev_alloc); drivers/clk/clkdev.c:274:1: warning: ‘vclkdev_alloc’ defined but not used [-Wunused-function] vclkdev_alloc(struct clk *clk, const char *con_id, const char *dev_fmt, Regards, Tony