From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753846AbbCCHwK (ORCPT ); Tue, 3 Mar 2015 02:52:10 -0500 Received: from bes.se.axis.com ([195.60.68.10]:43849 "EHLO bes.se.axis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751500AbbCCHwI (ORCPT ); Tue, 3 Mar 2015 02:52:08 -0500 Date: Tue, 3 Mar 2015 08:52:04 +0100 From: Jesper Nilsson To: Tejun Heo Cc: Jesper Nilsson , Rabin Vincent , Jesper Nilsson , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH for-3.20-fixes] workqueue: fix hang involving racing cancel[_delayed]_work_sync()'s for PREEMPT_NONE Message-ID: <20150303075204.GK11399@axis.com> References: <20150206171156.GA8942@axis.com> <20150209161527.GH3220@htj.duckdns.org> <20150302122615.GE11399@axis.com> <20150302162144.GF17694@htj.duckdns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150302162144.GF17694@htj.duckdns.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 02, 2015 at 11:21:44AM -0500, Tejun Heo wrote: > On Mon, Mar 02, 2015 at 01:26:15PM +0100, Jesper Nilsson wrote: > > On Mon, Feb 09, 2015 at 05:15:27PM +0100, Tejun Heo wrote: > > > Hello, > > > > Hi! > > > > > This patch removes the possible hang by updating __cancel_work_timer() > > > to explicitly wait for clearing of CANCELING rather than invoking > > > flush_work() after try_to_grab_pending() fails with -ENOENT. The > > > explicit wait uses the matching bit waitqueue for the CANCELING bit. > > > > > > Link: http://lkml.kernel.org/g/20150206171156.GA8942@axis.com > > > > > > Signed-off-by: Tejun Heo > > > Reported-by: Rabin Vincent > > > Cc: stable@vger.kernel.org > > > > What's the status on this patch, it's not in 4.0-rc1 at least? > > Is it queued for the 3.18 stable branch? > > Sorry about the delay. Applied to wq/for-4.0-fixes. Will push out in > a week or so. Thanks, that works great. Just wanted to know. :-) > Thanks. > > -- > tejun /^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nilsson@axis.com