From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756424AbbCCNB6 (ORCPT ); Tue, 3 Mar 2015 08:01:58 -0500 Received: from mail-wg0-f42.google.com ([74.125.82.42]:34765 "EHLO mail-wg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754839AbbCCNB5 (ORCPT ); Tue, 3 Mar 2015 08:01:57 -0500 Date: Tue, 3 Mar 2015 14:01:52 +0100 From: Ingo Molnar To: Arnaldo Carvalho de Melo Cc: linux-kernel@vger.kernel.org, David Ahern , Jiri Olsa , Namhyung Kim , Peter Zijlstra Subject: Re: [PATCH] perf tools: Improve Python feature detection messages Message-ID: <20150303130152.GA14527@gmail.com> References: <1425064989-26440-1-git-send-email-acme@kernel.org> <20150228081248.GA31856@gmail.com> <20150228083345.GB31887@gmail.com> <20150302151054.GB5538@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150302151054.GB5538@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Arnaldo Carvalho de Melo wrote: > Em Sat, Feb 28, 2015 at 09:33:45AM +0100, Ingo Molnar escreveu: > > > > Change the Python detection message from: > > > > config/Makefile:566: No python-config tool was found > > config/Makefile:566: Python support will not be built > > > > To: > > > > config/Makefile:565: No 'python-config' tool was found: disables Python support - please install python-devel/python-dev > > > > It's now a standard one-line message with a package install > > suggestion, and it also uses the standard language used by other > > feature detection messages. > > > > Signed-off-by: Ingo Molnar > > These patches came with no --- separating the log message from the > patch and the following hunk has no line number info for where to > apply the first hunk, fixing these up for you. Oops - I wasn't using a proper Git flow, just some crappy quick, ad-hoc manual patch creation flow ... Thanks, Ingo