From: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: outreachy-kernel@googlegroups.com, Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: [Outreachy kernel] [PATCH v3] staging: iio: meter: add check on return variables
Date: Tue, 3 Mar 2015 15:11:13 +0200 [thread overview]
Message-ID: <20150303131113.GD24979@waves> (raw)
In-Reply-To: <3934270.TZNMLNhXSS@wuerfel>
On Tue, Mar 03, 2015 at 01:13:09PM +0100, Arnd Bergmann wrote:
> On Tuesday 03 March 2015 07:01:47 Julia Lawall wrote:
> > > - ade7758_spi_read_reg_8(dev,
> > > - ADE7758_OPMODE,
> > > - &val);
> > > + ret = ade7758_spi_read_reg_8(dev, ADE7758_OPMODE, &val);
> > > + if (ret < 0) {
> > > + dev_err(dev, "failed to read from device");
> > > + goto error_ret;
> > > + }
> >
>
> The ade7758_spi_read_reg_8 already prints an error message, I don't
> think we want to see two messages about the same error.
>
good to know. Thanks Arnd!
> Arnd
--
Kind Regards,
Aya Saif El-yazal Mahfouz
next prev parent reply other threads:[~2015-03-03 13:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 11:27 [PATCH v3] staging: iio: meter: add check on return variables Aya Mahfouz
[not found] ` <CAEnQRZDFF_mvL=hUbC4T3S04kwUq1SZDqQdvWrd1_35Y8q_Uuw@mail.gmail.com>
2015-03-03 11:57 ` [Outreachy kernel] " Daniel Baluta
2015-03-03 12:01 ` Julia Lawall
2015-03-03 12:13 ` Arnd Bergmann
2015-03-03 13:11 ` Aya Mahfouz [this message]
2015-03-03 13:10 ` Aya Mahfouz
2015-03-03 22:37 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150303131113.GD24979@waves \
--to=mahfouz.saif.elyazal@gmail.com \
--cc=arnd@arndb.de \
--cc=julia.lawall@lip6.fr \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.