From: Vinod Koul <vinod.koul@intel.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Support Opensource <support.opensource@diasemi.com>
Subject: Re: [PATCH 3/3] ASoC: sn95031: Fix control-less DAPM routes
Date: Tue, 3 Mar 2015 21:55:12 +0530 [thread overview]
Message-ID: <20150303162512.GK2613@intel.com> (raw)
In-Reply-To: <1425042784-727-3-git-send-email-lars@metafoo.de>
On Fri, Feb 27, 2015 at 02:13:04PM +0100, Lars-Peter Clausen wrote:
> Routes without a control must use NULL for the control name. The sn95031
> driver uses "NULL" instead in a few places. Previous to commit 5fe5b767dc6f
> ("ASoC: dapm: Do not pretend to support controls for non mixer/mux widgets")
> the DAPM core silently ignored non-NULL controls on non-mixer and non-mux
> routes. But starting with that commit it will complain and not add the
> route breaking the sn95031 driver in the process.
>
> This patch replaces the incorrect "NULL" control name with NULL to fix the
> issue.
Acked-by: Vinod Koul <vinod.koul@intel.com>
--
~Vinod
next prev parent reply other threads:[~2015-03-03 16:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-27 13:13 [PATCH 1/3] ASoC: ak4671: Fix control-less DAPM routes Lars-Peter Clausen
2015-02-27 13:13 ` [PATCH 2/3] ASoC: da732x: " Lars-Peter Clausen
2015-03-02 10:36 ` Opensource [Adam Thomson]
2015-02-27 13:13 ` [PATCH 3/3] ASoC: sn95031: " Lars-Peter Clausen
2015-03-03 16:25 ` Vinod Koul [this message]
2015-03-05 1:00 ` [PATCH 1/3] ASoC: ak4671: " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150303162512.GK2613@intel.com \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=support.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.