From: Greg KH <gregkh@linuxfoundation.org>
To: Haneen Mohammed <hamohammed.sa@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH v10 4/4] Staging: emxx_udc: Clean dev_err() logging
Date: Tue, 3 Mar 2015 08:52:05 -0800 [thread overview]
Message-ID: <20150303165205.GA8132@kroah.com> (raw)
In-Reply-To: <20150302190228.GA12872@example.com>
On Mon, Mar 02, 2015 at 10:02:28PM +0300, Haneen Mohammed wrote:
> On Mon, Mar 02, 2015 at 10:54:12AM -0800, Greg KH wrote:
> > On Mon, Mar 02, 2015 at 09:45:23PM +0300, Haneen Mohammed wrote:
> > > This patch removes __func__ from dev_err.
> > > dev_err includes the function name in the log printout, so there is no
> > > need to include it manually.
> >
> > No, dev_err() does not include the function name, it includes much more
> > than that (device, driver, specific instance of device, etc.).
> >
> Noted. I learned about this from the logs.
> should I edit the commit msg and resed the patch?
Yes please.
next prev parent reply other threads:[~2015-03-03 18:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-02 18:25 [PATCH v10 0/4] Staging: emxx_udc: Fix checkpatch.pl warnings and remove extra code Haneen Mohammed
2015-03-02 18:33 ` [PATCH v10 1/4] Staging: emxx_udc: Remove argument test from function Haneen Mohammed
2015-03-02 18:37 ` [PATCH v10 2/4] Staging: emxx_udc: Replace custom printk macro ERR with dev_err or pr_err Haneen Mohammed
2015-03-02 18:38 ` [PATCH v10 3/4] Staging: emxx_udc: Remove custom printk macro ERR Haneen Mohammed
2015-03-02 18:45 ` [PATCH v10 4/4] Staging: emxx_udc: Clean dev_err() logging Haneen Mohammed
2015-03-02 18:54 ` [Outreachy kernel] " Greg KH
2015-03-02 19:02 ` Haneen Mohammed
2015-03-03 16:52 ` Greg KH [this message]
2015-03-04 9:10 ` [PATCH] " Haneen Mohammed
2015-03-06 23:29 ` [Outreachy kernel] " Greg KH
2015-03-07 17:08 ` Haneen Mohammed
2015-03-07 17:10 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150303165205.GA8132@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=hamohammed.sa@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.