From: Darren Hart <dvhart@infradead.org>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Bastien Nocera <hadess@hadess.net>, Jiri Kosina <jkosina@suse.cz>,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
ibm-acpi-devel@lists.sourceforge.net,
linux-input@vger.kernel.org
Subject: Re: [ibm-acpi-devel] [PATCH 1/7] thinkpad_acpi: Remember adaptive kbd presence
Date: Tue, 3 Mar 2015 08:52:25 -0800 [thread overview]
Message-ID: <20150303165225.GD83894@vmdeb7> (raw)
In-Reply-To: <1425035779.2000837.233193809.65561A3E@webmail.messagingengine.com>
On Fri, Feb 27, 2015 at 08:16:19AM -0300, Henrique de Moraes Holschuh wrote:
> On Fri, Feb 27, 2015, at 08:05, Henrique de Moraes Holschuh wrote:
> > On Thu, Feb 26, 2015, at 03:18, Darren Hart wrote:
> > > On Fri, Feb 20, 2015 at 03:44:10PM +0100, Bastien Nocera wrote:
> > > > Rather than checking on each suspend and resume whether the laptop
> > > > has an adaptive keyboard, check when the driver is initialised.
> > >
> > > Bastien, am I awaiting another version of this from you to address
> > > comments from
> > > Henrique?
> > >
> > > Henrique, when you're satisfied, please provide a Reviewed-by for the
> > > series.
> >
> > I usually provide a signed-off-by, as I am the thinkpad-acpi driver
> > maintainer... reviewed-by is implied in that case.
>
> Or an Acked-by, for that matter. Which is what I'd use for this series,
> since there is no reason to gatekeep it and it is being sent to you
> directly.
>
Henrique, I believe I may have overstepped with thinkpad-acpi and dealt with it
like the other drivers in platform/drivers/x86, when instead I should have been
leaving it to you. My apologies, it was not intentional.
Do you typically send pull-requests for the thinkpad-acpi driver
directly to Linus? Geeze, I see that the tree listed in MAINTAINERS is not even
mine. Ugh, my sincere apologies.
I would be more than happy to basically ignore anything to thinkpad-acpi until
after you have provided a review. I can also roll up pull requests from you if
you prefer to integrate into the platform-drivers-x86 tree as the path to Linus.
How do you want to handle your driver?
--
Darren Hart
Intel Open Source Technology Center
next prev parent reply other threads:[~2015-03-03 16:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-20 14:44 [PATCH 1/7] thinkpad_acpi: Remember adaptive kbd presence Bastien Nocera
2015-02-26 6:18 ` Darren Hart
2015-02-26 11:22 ` Bastien Nocera
2015-02-27 11:15 ` Henrique de Moraes Holschuh
2015-02-27 11:05 ` [ibm-acpi-devel] " Henrique de Moraes Holschuh
2015-02-27 11:16 ` Henrique de Moraes Holschuh
2015-03-03 16:52 ` Darren Hart [this message]
2015-03-03 18:39 ` Henrique de Moraes Holschuh
2015-03-03 18:39 ` [ibm-acpi-devel] " Henrique de Moraes Holschuh
2015-03-06 18:09 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150303165225.GD83894@vmdeb7 \
--to=dvhart@infradead.org \
--cc=hadess@hadess.net \
--cc=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.