Re: [Outreachy kernel] [PATCH v4] Staging: lustre: Remove extern in .c file

[Greg KH <gregkh@linuxfoundation.org>]

On Tue, Mar 03, 2015 at 01:03:00AM +0300, Haneen Mohammed wrote:
> This patch removes extern from .c file; for The variable is not used
> anywhere else in the file.
> Issue addressed by checkpatch.pl.
> 
> Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
> ---
> v4: remove extern declaration from .h
> 
>  drivers/staging/lustre/lustre/ldlm/ldlm_pool.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_pool.c b/drivers/staging/lustre/lustre/ldlm/ldlm_pool.c
> index d20d277..3d264e9 100644
> --- a/drivers/staging/lustre/lustre/ldlm/ldlm_pool.c
> +++ b/drivers/staging/lustre/lustre/ldlm/ldlm_pool.c
> @@ -141,8 +141,6 @@
>   */
>  #define LDLM_POOL_SLV_SHIFT (10)
>  
> -extern struct proc_dir_entry *ldlm_ns_proc_dir;
> -
>  static inline __u64 dru(__u64 val, __u32 shift, int round_up)
>  {
>  	return (val + (round_up ? (1 << shift) - 1 : 0)) >> shift;

Please also mark it static in the one file it is in in the same patch.

thanks,

greg k-h