All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrange" <berrange@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org,
	armbru@redhat.com, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH] configure: require glib 2.22
Date: Tue, 3 Mar 2015 17:21:42 +0000	[thread overview]
Message-ID: <20150303172127.GB21470@redhat.com> (raw)
In-Reply-To: <1425396255-14470-1-git-send-email-pbonzini@redhat.com>

On Tue, Mar 03, 2015 at 04:24:15PM +0100, Paolo Bonzini wrote:
> This provides g_ptr_array_new_with_free_func, as well as a few
> other functions that we've been hacking around in glib-compat.h.
> Cleaning up the compatibility headers will come later.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  configure |    8 +-------
>  1 files changed, 1 insertions(+), 7 deletions(-)

Fine with me - doesn't really help or hurt the I/O channels
work I'm doing to bring encryption to migration/chardev/etc.
It is certainly nice to not have different min versions for
native vs mingw though.

> 
> diff --git a/configure b/configure
> index 4d9a2a7..833bd69 100755
> --- a/configure
> +++ b/configure
> @@ -2745,13 +2745,7 @@ fi
>  ##########################################
>  # glib support probe
>  
> -if test "$mingw32" = yes; then
> -    # g_poll is required in order to integrate with the glib main loop.
> -    glib_req_ver=2.20
> -else
> -    glib_req_ver=2.12
> -fi
> -
> +glib_req_ver=2.22
>  glib_pkg_config()
>  {
>    if $pkg_config --atleast-version=$glib_req_ver $1; then

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

      parent reply	other threads:[~2015-03-03 17:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-03 15:24 [Qemu-devel] [PATCH] configure: require glib 2.22 Paolo Bonzini
2015-03-03 15:39 ` Igor Mammedov
2015-03-03 17:09 ` Michael S. Tsirkin
2015-03-04  7:42   ` Markus Armbruster
2015-03-04 14:02     ` Peter Maydell
2015-03-03 17:21 ` Daniel P. Berrange [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150303172127.GB21470@redhat.com \
    --to=berrange@redhat.com \
    --cc=armbru@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.