From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Joel Schopp <joel.schopp@amd.com>
Cc: Gleb Natapov <gleb@kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org, David Kaplan <David.Kaplan@amd.com>,
Joerg Roedel <joro@8bytes.org>,
linux-kernel@vger.kernel.org, Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH v3] x86: svm: use kvm_fast_pio_in()
Date: Tue, 3 Mar 2015 21:44:46 +0100 [thread overview]
Message-ID: <20150303204445.GC2494@potion.brq.redhat.com> (raw)
In-Reply-To: <54F61388.6090002@amd.com>
2015-03-03 14:03-0600, Joel Schopp:
> On 03/03/2015 10:44 AM, Radim Krčmář wrote:
> > 2015-03-02 15:02-0600, Joel Schopp:
> >> + int ret = emulator_pio_in_emulated(&vcpu->arch.emulate_ctxt, size,
> >> + port, &val, 1);
> > Btw. does this return 1 in some scenario?
> If a function returns a value it is always a good idea to check it and
> act appropriately. That said...
> emulator_pio_in_emulated will return 1 if emulator_pio_in_out returns 1
Ah, I have completely forgotten, thanks!
next prev parent reply other threads:[~2015-03-03 20:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-02 21:02 [PATCH v3] x86: svm: use kvm_fast_pio_in() Joel Schopp
2015-03-03 16:42 ` Radim Krčmář
2015-03-03 19:48 ` Joel Schopp
2015-03-03 20:42 ` Radim Krčmář
2015-04-07 12:55 ` Paolo Bonzini
2015-03-03 16:44 ` Radim Krčmář
2015-03-03 20:03 ` Joel Schopp
2015-03-03 20:44 ` Radim Krčmář [this message]
2015-03-13 0:47 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150303204445.GC2494@potion.brq.redhat.com \
--to=rkrcmar@redhat.com \
--cc=David.Kaplan@amd.com \
--cc=bp@alien8.de \
--cc=gleb@kernel.org \
--cc=joel.schopp@amd.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.