diff for duplicates of <20150304103101.GA9451@sloth> diff --git a/a/1.txt b/N1/1.txt index 39c7f2d..82168cf 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -45,10 +45,12 @@ f(...) { - int xname; <... ( - x - 1 + x = +- 1 + true | - x - -1 + x = +- -1 + false ) ...> @@ -107,7 +109,7 @@ index a47a191..050bc47 100644 - defect_flag = 0; + defect_flag = false; for (i = 0; i < segment->disable_count; i++) { - if (phy_blk = segment->defect_list[i]) { + if (phy_blk == segment->defect_list[i]) { - defect_flag = 1; + defect_flag = true; break; @@ -302,7 +304,7 @@ index 9593d81..35fa19d 100644 @@ -1625,7 +1629,7 @@ int rtsx_pre_handle_interrupt(struct rtsx_chip *chip) if (chip->ss_en) { chip->ss_counter = 0; - if (rtsx_get_stat(chip) = RTSX_STAT_SS) { + if (rtsx_get_stat(chip) == RTSX_STAT_SS) { - exit_ss = 1; + exit_ss = true; rtsx_exit_L1(chip); @@ -344,7 +346,7 @@ index 42645834..a00ba21 100644 @@ -520,7 +522,7 @@ static int inquiry(struct scsi_cmnd *srb, struct rtsx_chip *chip) if (chip->mspro_formatter_enable) #endif - if (!card || (card = MS_CARD)) + if (!card || (card == MS_CARD)) - pro_formatter_flag = 1; + pro_formatter_flag = true; @@ -358,7 +360,7 @@ index 42645834..a00ba21 100644 + bool support_format = false; int i = 0; - if (cmd = MODE_SENSE) { + if (cmd == MODE_SENSE) { @@ -684,10 +686,10 @@ static void ms_mode_sense(struct rtsx_chip *chip, u8 cmd, /* Medium Type Code */ if (check_card_ready(chip, lun)) { @@ -390,7 +392,7 @@ index 42645834..a00ba21 100644 dataSize = 8; #ifdef SUPPORT_MAGIC_GATE if ((chip->lun2card[lun] & MS_CARD)) { - if (!card || (card = MS_CARD)) { + if (!card || (card == MS_CARD)) { dataSize = 108; if (chip->mspro_formatter_enable) - pro_formatter_flag = 1; @@ -398,7 +400,7 @@ index 42645834..a00ba21 100644 } } #else - if (card = MS_CARD) { + if (card == MS_CARD) { if (chip->mspro_formatter_enable) { - pro_formatter_flag = 1; + pro_formatter_flag = true; @@ -483,7 +485,7 @@ index c28a927..62bf570 100644 @@ -1137,7 +1137,7 @@ static int sd_check_switch(struct rtsx_chip *chip, retval = sd_check_switch_mode(chip, SD_SWITCH_MODE, func_group, func_to_switch, bus_width); - if (retval = STATUS_SUCCESS) { + if (retval == STATUS_SUCCESS) { - switch_good = 1; + switch_good = true; break; @@ -498,7 +500,7 @@ index c28a927..62bf570 100644 + int max_len, final_path_idx; u8 final_phase = 0xFF; - if (phase_map = 0xFFFFFFFF) { + if (phase_map == 0xFFFFFFFF) { @@ -1537,12 +1538,12 @@ static u8 sd_search_final_phase(struct rtsx_chip *chip, u32 phase_map, } @@ -555,8 +557,8 @@ index c28a927..62bf570 100644 if (sd_card->sd_lock_status & SD_UNLOCK_POW_ON) @@ -2217,7 +2219,7 @@ RTY_SD_RST: SD_RSP_TYPE_R7, rsp, 5); - if (retval = STATUS_SUCCESS) { - if ((rsp[4] = 0xAA) && ((rsp[3] & 0x0f) = 0x01)) { + if (retval == STATUS_SUCCESS) { + if ((rsp[4] == 0xAA) && ((rsp[3] & 0x0f) == 0x01)) { - hi_cap_flow = 1; + hi_cap_flow = true; voltage = SUPPORT_VOLTAGE | 0x40000000; diff --git a/a/content_digest b/N1/content_digest index b0759b8..eadf5dd 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,6 +1,6 @@ "From\0Quentin Lambert <lambert.quentin@gmail.com>\0" "Subject\0[PATCH 1/2] staging: rts5208: Convert non-returned local variable to boolean when relevant\0" - "Date\0Wed, 04 Mar 2015 10:31:01 +0000\0" + "Date\0Wed, 4 Mar 2015 11:31:01 +0100\0" "To\0Greg Kroah-Hartman <gregkh@linuxfoundation.org>\0" "Cc\0kernel-janitors@vger.kernel.org" devel@driverdev.osuosl.org @@ -54,10 +54,12 @@ "- int xname;\n" "<...\n" "(\n" - " x - 1\n" + " x =\n" + "- 1\n" "+ true\n" "|\n" - " x - -1\n" + " x =\n" + "- -1\n" "+ false\n" ")\n" "...>\n" @@ -116,7 +118,7 @@ "-\t\t\tdefect_flag = 0;\n" "+\t\t\tdefect_flag = false;\n" " \t\t\tfor (i = 0; i < segment->disable_count; i++) {\n" - " \t\t\t\tif (phy_blk = segment->defect_list[i]) {\n" + " \t\t\t\tif (phy_blk == segment->defect_list[i]) {\n" "-\t\t\t\t\tdefect_flag = 1;\n" "+\t\t\t\t\tdefect_flag = true;\n" " \t\t\t\t\tbreak;\n" @@ -311,7 +313,7 @@ "@@ -1625,7 +1629,7 @@ int rtsx_pre_handle_interrupt(struct rtsx_chip *chip)\n" " \tif (chip->ss_en) {\n" " \t\tchip->ss_counter = 0;\n" - " \t\tif (rtsx_get_stat(chip) = RTSX_STAT_SS) {\n" + " \t\tif (rtsx_get_stat(chip) == RTSX_STAT_SS) {\n" "-\t\t\texit_ss = 1;\n" "+\t\t\texit_ss = true;\n" " \t\t\trtsx_exit_L1(chip);\n" @@ -353,7 +355,7 @@ "@@ -520,7 +522,7 @@ static int inquiry(struct scsi_cmnd *srb, struct rtsx_chip *chip)\n" " \tif (chip->mspro_formatter_enable)\n" " #endif\n" - " \t\tif (!card || (card = MS_CARD))\n" + " \t\tif (!card || (card == MS_CARD))\n" "-\t\t\tpro_formatter_flag = 1;\n" "+\t\t\tpro_formatter_flag = true;\n" " \n" @@ -367,7 +369,7 @@ "+\tbool support_format = false;\n" " \tint i = 0;\n" " \n" - " \tif (cmd = MODE_SENSE) {\n" + " \tif (cmd == MODE_SENSE) {\n" "@@ -684,10 +686,10 @@ static void ms_mode_sense(struct rtsx_chip *chip, u8 cmd,\n" " \t/* Medium Type Code */\n" " \tif (check_card_ready(chip, lun)) {\n" @@ -399,7 +401,7 @@ " \tdataSize = 8;\n" " #ifdef SUPPORT_MAGIC_GATE\n" " \tif ((chip->lun2card[lun] & MS_CARD)) {\n" - " \t\tif (!card || (card = MS_CARD)) {\n" + " \t\tif (!card || (card == MS_CARD)) {\n" " \t\t\tdataSize = 108;\n" " \t\t\tif (chip->mspro_formatter_enable)\n" "-\t\t\t\tpro_formatter_flag = 1;\n" @@ -407,7 +409,7 @@ " \t\t}\n" " \t}\n" " #else\n" - " \tif (card = MS_CARD) {\n" + " \tif (card == MS_CARD) {\n" " \t\tif (chip->mspro_formatter_enable) {\n" "-\t\t\tpro_formatter_flag = 1;\n" "+\t\t\tpro_formatter_flag = true;\n" @@ -492,7 +494,7 @@ "@@ -1137,7 +1137,7 @@ static int sd_check_switch(struct rtsx_chip *chip,\n" " \t\t\tretval = sd_check_switch_mode(chip, SD_SWITCH_MODE,\n" " \t\t\t\t\tfunc_group, func_to_switch, bus_width);\n" - " \t\t\tif (retval = STATUS_SUCCESS) {\n" + " \t\t\tif (retval == STATUS_SUCCESS) {\n" "-\t\t\t\tswitch_good = 1;\n" "+\t\t\t\tswitch_good = true;\n" " \t\t\t\tbreak;\n" @@ -507,7 +509,7 @@ "+\tint max_len, final_path_idx;\n" " \tu8 final_phase = 0xFF;\n" " \n" - " \tif (phase_map = 0xFFFFFFFF) {\n" + " \tif (phase_map == 0xFFFFFFFF) {\n" "@@ -1537,12 +1538,12 @@ static u8 sd_search_final_phase(struct rtsx_chip *chip, u32 phase_map,\n" " \t}\n" " \n" @@ -564,8 +566,8 @@ " \tif (sd_card->sd_lock_status & SD_UNLOCK_POW_ON)\n" "@@ -2217,7 +2219,7 @@ RTY_SD_RST:\n" " \t\t\t\tSD_RSP_TYPE_R7, rsp, 5);\n" - " \tif (retval = STATUS_SUCCESS) {\n" - " \t\tif ((rsp[4] = 0xAA) && ((rsp[3] & 0x0f) = 0x01)) {\n" + " \tif (retval == STATUS_SUCCESS) {\n" + " \t\tif ((rsp[4] == 0xAA) && ((rsp[3] & 0x0f) == 0x01)) {\n" "-\t\t\thi_cap_flow = 1;\n" "+\t\t\thi_cap_flow = true;\n" " \t\t\tvoltage = SUPPORT_VOLTAGE | 0x40000000;\n" @@ -748,4 +750,4 @@ "-- \n" 1.9.1 -40bf7554cee150a5176d6c06c59614920bcb3bc963807271b7840d799d3dd366 +a22f0a9a210c98064c0ec4fd9e2e9ab8d94e608d7a306f7ae6847acb04693eed
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.