From mboxrd@z Thu Jan 1 00:00:00 1970 From: vinod.koul@intel.com (Vinod Koul) Date: Wed, 4 Mar 2015 17:32:50 +0530 Subject: [PATCH] dma: xilinx-dma: move header file to common location In-Reply-To: <2793259.VbbYy9Imif@wuerfel> References: <4c3e2425e14646cb86c20d6aebdcfe22@BY2FFO11FD004.protection.gbl> <2793259.VbbYy9Imif@wuerfel> Message-ID: <20150304120250.GO2613@intel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Mar 02, 2015 at 08:28:01PM +0100, Arnd Bergmann wrote: > On Monday 02 March 2015 23:24:24 Kedareswara rao Appana wrote: > > This patch moves the xilinx_dma.h header file > > to the include/linux/dma. > > > > Signed-off-by: Kedareswara rao Appana > > Please move this header file to drivers/dma/xilinx/ directly to > make it inaccessible by other driver. No driver should pass extra > data structures to a dmaengine driver. Actually that is not true. Few of the drivers need some additional parameters to be set which are not covered by the common set, hence an additional API is exposed by this driver to do so... If ever we could get rid of these... -- ~Vinod From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933248AbbCDMGK (ORCPT ); Wed, 4 Mar 2015 07:06:10 -0500 Received: from mga11.intel.com ([192.55.52.93]:37836 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753919AbbCDMGH (ORCPT ); Wed, 4 Mar 2015 07:06:07 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,687,1418112000"; d="scan'208";a="693795173" Date: Wed, 4 Mar 2015 17:32:50 +0530 From: Vinod Koul To: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, Kedareswara rao Appana , dan.j.williams@intel.com, michal.simek@xilinx.com, soren.brinkmann@xilinx.com, svemula@xilinx.com, linux-kernel@vger.kernel.org, anirudh@xilinx.com, dmaengine@vger.kernel.org, appanad@xilinx.com Subject: Re: [PATCH] dma: xilinx-dma: move header file to common location Message-ID: <20150304120250.GO2613@intel.com> References: <4c3e2425e14646cb86c20d6aebdcfe22@BY2FFO11FD004.protection.gbl> <2793259.VbbYy9Imif@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2793259.VbbYy9Imif@wuerfel> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 02, 2015 at 08:28:01PM +0100, Arnd Bergmann wrote: > On Monday 02 March 2015 23:24:24 Kedareswara rao Appana wrote: > > This patch moves the xilinx_dma.h header file > > to the include/linux/dma. > > > > Signed-off-by: Kedareswara rao Appana > > Please move this header file to drivers/dma/xilinx/ directly to > make it inaccessible by other driver. No driver should pass extra > data structures to a dmaengine driver. Actually that is not true. Few of the drivers need some additional parameters to be set which are not covered by the common set, hence an additional API is exposed by this driver to do so... If ever we could get rid of these... -- ~Vinod