From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36699)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ehabkost@redhat.com>) id 1YTAou-0001gl-Ft
	for qemu-devel@nongnu.org; Wed, 04 Mar 2015 10:02:50 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ehabkost@redhat.com>) id 1YTAop-0001Ef-HZ
	for qemu-devel@nongnu.org; Wed, 04 Mar 2015 10:02:44 -0500
Received: from mx1.redhat.com ([209.132.183.28]:49313)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ehabkost@redhat.com>) id 1YTAop-0001EU-9a
	for qemu-devel@nongnu.org; Wed, 04 Mar 2015 10:02:39 -0500
Date: Wed, 4 Mar 2015 12:02:31 -0300
From: Eduardo Habkost <ehabkost@redhat.com>
Message-ID: <20150304150231.GS3513@thinpad.lan.raisama.net>
References: <1425435224-2630-1-git-send-email-ehabkost@redhat.com>
	<1425435224-2630-4-git-send-email-ehabkost@redhat.com>
	<54F714C7.1070104@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <54F714C7.1070104@suse.de>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v4 3/5] target-i386: Move
 CPUX86State.cpuid_apic_id to X86CPU.apic_id
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>
Cc: Gu Zheng <guz.fnst@cn.fujitsu.com>, Igor Mammedov <imammedo@redhat.com>, qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>

On Wed, Mar 04, 2015 at 03:20:55PM +0100, Andreas F=E4rber wrote:
> Am 04.03.2015 um 03:13 schrieb Eduardo Habkost:
> > The field doesn't need to be inside CPUState, and it is not specific =
for
>=20
> You mean CPUX86State or CPUArchState, I guess. :)
>=20
> > the CPUID instruction, so move and rename it.
> >=20
> > Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
> > Reviewed-by: Andreas F=E4rber <afaerber@suse.de>
> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
>=20
> Could you please use Class::field syntax for consistency when you apply=
?

Will fix both issues. Thanks!

--=20
Eduardo