Re: [Outreachy kernel] [PATCH 08/13] staging: rtl8192u: remove extra parentheses around right bit shift operation

[Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>]

On Wed, Mar 04, 2015 at 12:09:40PM -0500, Julia Lawall wrote:
> > diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
> > index 9de4412..bab7751 100644
> > --- a/drivers/staging/rtl8192u/r8192U_core.c
> > +++ b/drivers/staging/rtl8192u/r8192U_core.c
> > @@ -2310,11 +2310,11 @@ static void rtl8192_read_eeprom_info(struct net_device *dev)
> >  	}
> >
> >  	if (bLoad_From_EEPOM) {
> > -		tmpValue = eprom_read(dev, (EEPROM_VID>>1));
> > +		tmpValue = eprom_read(dev, EEPROM_VID>>1);
> 
> Perhaps you could add some spaces around >> at the same time.
>
Yes, I realized the styling issue too, it can be found in many files.
Coders are not consistent when it comes to leaving spaces around
the >> and << operators and checkpatch does not complain. In addition,
checkpatch does not issue any warning about where an operator should
be if a statement is split into two or more lines
e.g.

s = a * 
   b;
is the same as 
s = a 
   * b;

I can send the styling issues handling in a separate patchset. If you
want me to resend the patchset again, let me know. It will however take
me some time.
   
> julia
> 
> >  		priv->eeprom_vid = endian_swap(&tmpValue);
> > -		priv->eeprom_pid = eprom_read(dev, (EEPROM_PID>>1));
> > -		tmpValue = eprom_read(dev, (EEPROM_ChannelPlan>>1));
> > -		priv->eeprom_ChannelPlan = ((tmpValue&0xff00)>>8);
> > +		priv->eeprom_pid = eprom_read(dev, EEPROM_PID>>1);
> > +		tmpValue = eprom_read(dev, EEPROM_ChannelPlan>>1);
> > +		priv->eeprom_ChannelPlan = (tmpValue & 0xff00)>>8;
> >  		priv->btxpowerdata_readfromEEPORM = true;
> >  		priv->eeprom_CustomerID = eprom_read(dev, (EEPROM_Customer_ID>>1)) >>8;
> >  	} else {
> > @@ -2397,7 +2397,8 @@ static void rtl8192_read_eeprom_info(struct net_device *dev)
> >  			}
> >  		} else if (priv->EEPROM_Def_Ver == 1) {
> >  			if (bLoad_From_EEPOM) {
> > -				tmpValue = eprom_read(dev, (EEPROM_TxPwIndex_CCK_V1>>1));
> > +				tmpValue = eprom_read(dev,
> > +						EEPROM_TxPwIndex_CCK_V1 >> 1);
> >  				tmpValue = (tmpValue & 0xff00) >> 8;
> >  			} else {
> >  				tmpValue = 0x10;
> > @@ -2410,7 +2411,8 @@ static void rtl8192_read_eeprom_info(struct net_device *dev)
> >  				tmpValue = 0x1010;
> >  			*((u16 *)(&priv->EEPROMTxPowerLevelCCK_V1[1])) = tmpValue;
> >  			if (bLoad_From_EEPOM)
> > -				tmpValue = eprom_read(dev, (EEPROM_TxPwIndex_OFDM_24G_V1>>1));
> > +				tmpValue = eprom_read(dev,
> > +					EEPROM_TxPwIndex_OFDM_24G_V1 >> 1);
> >  			else
> >  				tmpValue = 0x1010;
> >  			*((u16 *)(&priv->EEPROMTxPowerLevelOFDM24G[0])) = tmpValue;
> > @@ -2453,7 +2455,7 @@ static void rtl8192_read_eeprom_info(struct net_device *dev)
> >  		// Antenna B gain offset to antenna A, bit0~3
> >  		priv->AntennaTxPwDiff[0] = (priv->EEPROMTxPowerDiff & 0xf);
> >  		// Antenna C gain offset to antenna A, bit4~7
> > -		priv->AntennaTxPwDiff[1] = ((priv->EEPROMTxPowerDiff & 0xf0)>>4);
> > +		priv->AntennaTxPwDiff[1] = (priv->EEPROMTxPowerDiff & 0xf0)>>4;
> >  		// CrystalCap, bit12~15
> >  		priv->CrystalCap = priv->EEPROMCrystalCap;
> >  		// ThermalMeter, bit0~3 for RFIC1, bit4~7 for RFIC2
> > --
> > 1.9.3
> >
> >
> > --
> > Kind Regards,
> > Aya Saif El-yazal Mahfouz
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/076f797b7a1c3417bb6fe5d027a4a21d5e33b072.1425446659.git.mahfouz.saif.elyazal%40gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
> >

-- 
Kind Regards,
Aya Saif El-yazal Mahfouz