From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760035AbbCDSrt (ORCPT ); Wed, 4 Mar 2015 13:47:49 -0500 Received: from mail.skyhub.de ([78.46.96.112]:49457 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759901AbbCDSrs (ORCPT ); Wed, 4 Mar 2015 13:47:48 -0500 Date: Wed, 4 Mar 2015 19:46:34 +0100 From: Borislav Petkov To: Darshana Padmadas Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, josh@joshtriplett.org Subject: Re: [PATCH 05/16] arch: x86: kernel: Make internal functions static in cpu/intel_cacheinfo.c Message-ID: <20150304184634.GA3526@pd.tnic> References: <63cb1aefe4d19b7526fe1ae2fb8066152eba1c8b.1425473428.git.darshanapadmadas@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <63cb1aefe4d19b7526fe1ae2fb8066152eba1c8b.1425473428.git.darshanapadmadas@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 04, 2015 at 07:02:07PM +0530, Darshana Padmadas wrote: > cpu/intel_cacheinfo.c defines two functions amd_get_l3_disable_slot > and amd_set_l3_disable_slot. No other file uses these functions. > So make these static. > > This eliminates the following warnings: > > arch/x86/kernel/cpu/intel_cacheinfo.c:349:5: warning: no previous prototype for ‘amd_get_l3_disable_slot’ [-Wmissing-prototypes] > arch/x86/kernel/cpu/intel_cacheinfo.c:427:5: warning: no previous prototype for ‘amd_set_l3_disable_slot’ [-Wmissing-prototypes] Please correct your commit message - this patch is making functions static and not fixing -Wmissing-prototypes warnings. Also, go through the rest of the patchset as I see other cases of this too. Thanks. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --