Re: [PATCH] dmaengine: bam-dma: fill slave directions bit mask

[Andy Gross <agross@codeaurora.org>]

On Wed, Mar 04, 2015 at 09:32:13PM +0530, Vinod Koul wrote:
> On Wed, Mar 04, 2015 at 05:25:10PM +0200, Stanimir Varbanov wrote:
> > This will avoid warning during async device registration.
> > 
> > Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
> > ---
> >  drivers/dma/qcom_bam_dma.c |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/drivers/dma/qcom_bam_dma.c b/drivers/dma/qcom_bam_dma.c
> > index c3113e3..cc9e5ee 100644
> > --- a/drivers/dma/qcom_bam_dma.c
> > +++ b/drivers/dma/qcom_bam_dma.c
> > @@ -1143,6 +1143,7 @@ static int bam_dma_probe(struct platform_device *pdev)
> >  	dma_cap_set(DMA_SLAVE, bdev->common.cap_mask);
> >  
> >  	/* initialize dmaengine apis */
> > +	bdev->common.directions = BIT(DMA_DEV_TO_MEM) | BIT(DMA_MEM_TO_DEV);
> >  	bdev->common.device_alloc_chan_resources = bam_alloc_chan;
> >  	bdev->common.device_free_chan_resources = bam_free_chan;
> >  	bdev->common.device_prep_slave_sg = bam_prep_slave_sg;
> You need to fill other fields, src/dstn_addr_widths and
> residue_granularity...

Add segment granularity for BAM, as we can read the current completed segment.
bdev->common.residue_granularity = DMA_RESIDUE_GRANULARITY_SEGMENT;

Use DMA_SLAVE_BUSWIDTH_4_BYTES for the src/dst addr width:
bdev->common.src_addr_widths = DMA_SLAVE_BUSWIDTH_4_BYTES;
bdev->common.dst_addr_widths = DMA_SLAVE_BUSWIDTH_4_BYTES;

-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project