From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: akash.goel@intel.com
Cc: ankitprasad.r.sharma@intel.com, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 09/10] drm/i915/skl: Updated the act_freq_mhz_show sysfs function
Date: Thu, 5 Mar 2015 12:22:09 +0200 [thread overview]
Message-ID: <20150305102209.GC11371@intel.com> (raw)
In-Reply-To: <1424954986-24450-10-git-send-email-akash.goel@intel.com>
On Thu, Feb 26, 2015 at 06:19:45PM +0530, akash.goel@intel.com wrote:
> From: Akash Goel <akash.goel@intel.com>
>
> Added support for SKL in the act_freq_mhz_show sysfs function
>
> Signed-off-by: Akash Goel <akash.goel@intel.com>
Again required a bit of mail juggling to double chekc the definition,
but looks correct.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_sysfs.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_sysfs.c b/drivers/gpu/drm/i915/i915_sysfs.c
> index 186ab95..57e1186 100644
> --- a/drivers/gpu/drm/i915/i915_sysfs.c
> +++ b/drivers/gpu/drm/i915/i915_sysfs.c
> @@ -300,7 +300,9 @@ static ssize_t gt_act_freq_mhz_show(struct device *kdev,
> ret = intel_gpu_freq(dev_priv, (freq >> 8) & 0xff);
> } else {
> u32 rpstat = I915_READ(GEN6_RPSTAT1);
> - if (IS_HASWELL(dev_priv) || IS_BROADWELL(dev_priv))
> + if (IS_GEN9(dev_priv))
> + ret = (rpstat & GEN9_CAGF_MASK) >> GEN9_CAGF_SHIFT;
> + else if (IS_HASWELL(dev_priv) || IS_BROADWELL(dev_priv))
> ret = (rpstat & HSW_CAGF_MASK) >> HSW_CAGF_SHIFT;
> else
> ret = (rpstat & GEN6_CAGF_MASK) >> GEN6_CAGF_SHIFT;
> --
> 1.9.2
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-03-05 10:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-26 12:49 [PATCH v3 00/10] Added missing changes for Turbo feature on SKL akash.goel
2015-02-26 12:49 ` [PATCH 1/8] drm/i915/skl: Added new macros akash.goel
2015-02-26 12:50 ` Chris Wilson
2015-02-26 12:51 ` Chris Wilson
2015-03-05 8:42 ` Akash Goel
2015-03-05 8:45 ` Chris Wilson
2015-02-26 12:49 ` [PATCH 2/8] drm/i915/skl: Updated intel_gpu_freq() and intel_freq_opcode() akash.goel
2015-03-05 10:18 ` Ville Syrjälä
2015-02-26 12:49 ` [PATCH 3/8] drm/i915/skl: Updated the gen6_init_rps_frequencies function akash.goel
2015-03-05 10:14 ` Ville Syrjälä
2015-03-05 10:26 ` Akash Goel
2015-02-26 12:49 ` [PATCH 4/8] drm/i915/skl: Updated the gen6_set_rps function akash.goel
2015-03-05 10:20 ` Ville Syrjälä
2015-02-26 12:49 ` [PATCH 5/8] drm/i915/skl: Restructured the gen6_set_rps_thresholds function akash.goel
2015-02-26 12:49 ` Chris Wilson
2015-02-26 12:49 ` [PATCH 6/8] drm/i915/skl: Updated the gen6_rps_limits function akash.goel
2015-03-05 10:20 ` Ville Syrjälä
2015-02-26 12:49 ` [PATCH 7/8] drm/i915/skl: Updated the gen9_enable_rps function akash.goel
2015-02-26 12:49 ` [PATCH 8/8] drm/i915/skl: Updated the i915_frequency_info debugfs function akash.goel
2015-02-28 9:57 ` shuang.he
2015-02-26 12:49 ` [PATCH 09/10] drm/i915/skl: Updated the act_freq_mhz_show sysfs function akash.goel
2015-03-05 10:22 ` Ville Syrjälä [this message]
2015-02-26 12:49 ` [PATCH 10/10] drm/i915/skl: Enabling processing of Turbo interrupts akash.goel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150305102209.GC11371@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=akash.goel@intel.com \
--cc=ankitprasad.r.sharma@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.