From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Thu, 05 Mar 2015 14:10:40 +0100 (CET) Received: from aserp1040.oracle.com ([141.146.126.69]:33881 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27007189AbbCENKhjrNXr (ORCPT ); Thu, 5 Mar 2015 14:10:37 +0100 Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t25D9P2u014644 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 5 Mar 2015 13:09:26 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0021.oracle.com (8.13.8/8.13.8) with ESMTP id t25D9P5g005991 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 5 Mar 2015 13:09:25 GMT Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by aserv0122.oracle.com (8.13.8/8.13.8) with ESMTP id t25D9OJT022581; Thu, 5 Mar 2015 13:09:24 GMT Received: from mwanda (/154.0.139.178) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 05 Mar 2015 05:09:18 -0800 Date: Thu, 5 Mar 2015 16:08:50 +0300 From: Dan Carpenter To: Valentin Rothberg Cc: akpm@linux-foundation.org, Jonathan Corbet , Ralf Baechle , David Woodhouse , Brian Norris , Greg Kroah-Hartman , Paul Bolle , Jiri Kosina , Ewan Milne , Hannes Reinecke , Christoph Hellwig , Huacai Chen , Hongliang Tao , Nishanth Menon , Santosh Shilimkar , Peter Ujfalusi , Tony Lindgren , Rajendra Nayak , Sricharan R , Afzal Mohammed , Keerthy , Zhou Wang , Felipe Balbi , Laurent Pinchart , Thomas Gleixner , Randy Dunlap , Kukjin Kim , "Rafael J. Wysocki" , Quentin Lambert , Eyal Perry , Arnd Bergmann , Peter Zijlstra , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, iss_storagedev@hp.com, linux-mtd@lists.infradead.org, linux-usb@vger.kernel.org Subject: Re: [PATCH] Remove deprecated IRQF_DISABLED flag entirely Message-ID: <20150305130850.GK5437@mwanda> References: <1425560442-13367-1-git-send-email-valentinrothberg@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1425560442-13367-1-git-send-email-valentinrothberg@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 46200 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: dan.carpenter@oracle.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Thu, Mar 05, 2015 at 01:59:39PM +0100, Valentin Rothberg wrote: > diff --git a/drivers/mtd/nand/hisi504_nand.c b/drivers/mtd/nand/hisi504_nand.c > index 289ad3ac3e80..7f9f9c827c1d 100644 > --- a/drivers/mtd/nand/hisi504_nand.c > +++ b/drivers/mtd/nand/hisi504_nand.c > @@ -758,8 +758,7 @@ static int hisi_nfc_probe(struct platform_device *pdev) > > hisi_nfc_host_init(host); > > - ret = devm_request_irq(dev, irq, hinfc_irq_handle, IRQF_DISABLED, > - "nandc", host); > + ret = devm_request_irq(dev, irq, hinfc_irq_handle, "nandc", host); I think this breaks the build. > if (ret) { > dev_err(dev, "failed to request IRQ\n"); > goto err_res; regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from aserp1040.oracle.com ([141.146.126.69]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YTVYL-00027K-NJ for linux-mtd@lists.infradead.org; Thu, 05 Mar 2015 13:11:02 +0000 Date: Thu, 5 Mar 2015 16:08:50 +0300 From: Dan Carpenter To: Valentin Rothberg Subject: Re: [PATCH] Remove deprecated IRQF_DISABLED flag entirely Message-ID: <20150305130850.GK5437@mwanda> References: <1425560442-13367-1-git-send-email-valentinrothberg@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1425560442-13367-1-git-send-email-valentinrothberg@gmail.com> Cc: Nishanth Menon , linux-mips@linux-mips.org, Quentin Lambert , Jiri Kosina , Tony Lindgren , Peter Ujfalusi , Sricharan R , linux-mtd@lists.infradead.org, Felipe Balbi , Huacai Chen , Christoph Hellwig , Kukjin Kim , iss_storagedev@hp.com, Jonathan Corbet , "Rafael J. Wysocki" , Ewan Milne , Peter Zijlstra , Afzal Mohammed , Arnd Bergmann , Rajendra Nayak , Eyal Perry , Hannes Reinecke , Thomas Gleixner , Paul Bolle , Keerthy , Randy Dunlap , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Ralf Baechle , Zhou Wang , linux-usb@vger.kernel.org, Santosh Shilimkar , Greg Kroah-Hartman , Hongliang Tao , akpm@linux-foundation.org, Brian Norris , David Woodhouse , Laurent Pinchart List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, Mar 05, 2015 at 01:59:39PM +0100, Valentin Rothberg wrote: > diff --git a/drivers/mtd/nand/hisi504_nand.c b/drivers/mtd/nand/hisi504_nand.c > index 289ad3ac3e80..7f9f9c827c1d 100644 > --- a/drivers/mtd/nand/hisi504_nand.c > +++ b/drivers/mtd/nand/hisi504_nand.c > @@ -758,8 +758,7 @@ static int hisi_nfc_probe(struct platform_device *pdev) > > hisi_nfc_host_init(host); > > - ret = devm_request_irq(dev, irq, hinfc_irq_handle, IRQF_DISABLED, > - "nandc", host); > + ret = devm_request_irq(dev, irq, hinfc_irq_handle, "nandc", host); I think this breaks the build. > if (ret) { > dev_err(dev, "failed to request IRQ\n"); > goto err_res; regards, dan carpenter