From: alexandre.belloni@free-electrons.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 5/9] ARM: at91: add soc detection infrastructure
Date: Thu, 5 Mar 2015 16:52:34 +0100 [thread overview]
Message-ID: <20150305155234.GU3989@piout.net> (raw)
In-Reply-To: <1425580851.g2DuYFu1co@ws-stein>
On 05/03/2015 at 16:29:26 +0100, Alexander Stein wrote :
> > + if (!regs) {
> > + pr_warn("Could not map DBGU iomem range");
> > + iounmap(regs);
>
> I guess if regs == NULL there is no need to iounmap them, no?
>
Indeed :)
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Alexander Stein <alexander.stein@systec-electronic.com>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Boris Brezillon <boris.brezillon@free-electrons.com>
Subject: Re: [PATCH v2 5/9] ARM: at91: add soc detection infrastructure
Date: Thu, 5 Mar 2015 16:52:34 +0100 [thread overview]
Message-ID: <20150305155234.GU3989@piout.net> (raw)
In-Reply-To: <1425580851.g2DuYFu1co@ws-stein>
On 05/03/2015 at 16:29:26 +0100, Alexander Stein wrote :
> > + if (!regs) {
> > + pr_warn("Could not map DBGU iomem range");
> > + iounmap(regs);
>
> I guess if regs == NULL there is no need to iounmap them, no?
>
Indeed :)
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-03-05 15:52 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-05 12:11 [PATCH v2 0/9] ARM: at91 cleanups for 4.1 #1 Alexandre Belloni
2015-03-05 12:11 ` Alexandre Belloni
2015-03-05 12:11 ` [PATCH v2 1/9] ARM: at91: remove NEED_MACH_IO_H Alexandre Belloni
2015-03-05 12:11 ` Alexandre Belloni
2015-03-05 12:11 ` [PATCH v2 2/9] ARM: at91: remove unused at91_ioremap_matrix and header Alexandre Belloni
2015-03-05 12:11 ` Alexandre Belloni
2015-03-05 12:11 ` [PATCH v2 3/9] ARM: at91: remove unused _matrix.h headers Alexandre Belloni
2015-03-05 12:11 ` Alexandre Belloni
2015-03-05 12:11 ` [PATCH v2 4/9] ARM: at91/dt: introduce atmel,<chip>-dbgu Alexandre Belloni
2015-03-05 12:11 ` Alexandre Belloni
2015-03-05 12:11 ` [PATCH v2 5/9] ARM: at91: add soc detection infrastructure Alexandre Belloni
2015-03-05 12:11 ` Alexandre Belloni
2015-03-05 15:29 ` Alexander Stein
2015-03-05 15:29 ` Alexander Stein
2015-03-05 15:52 ` Alexandre Belloni [this message]
2015-03-05 15:52 ` Alexandre Belloni
2015-03-05 12:11 ` [PATCH v2 6/9] ARM: at91: at91rm9200 use SoC " Alexandre Belloni
2015-03-05 12:11 ` Alexandre Belloni
2015-03-05 12:11 ` [PATCH v2 7/9] ARM: at91: at91sam9: " Alexandre Belloni
2015-03-05 12:11 ` Alexandre Belloni
2015-03-05 12:11 ` [PATCH v2 8/9] ARM: at91: sama5 " Alexandre Belloni
2015-03-05 12:11 ` Alexandre Belloni
2015-03-05 12:11 ` [PATCH v2 9/9] ARM: at91: remove old setup Alexandre Belloni
2015-03-05 12:11 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150305155234.GU3989@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.