From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41814)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ehabkost@redhat.com>) id 1YTcbp-0005og-5L
	for qemu-devel@nongnu.org; Thu, 05 Mar 2015 15:43:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ehabkost@redhat.com>) id 1YTcbk-0005kT-UP
	for qemu-devel@nongnu.org; Thu, 05 Mar 2015 15:43:05 -0500
Received: from mx1.redhat.com ([209.132.183.28]:39295)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ehabkost@redhat.com>) id 1YTcbk-0005k2-NS
	for qemu-devel@nongnu.org; Thu, 05 Mar 2015 15:43:00 -0500
Date: Thu, 5 Mar 2015 13:48:35 -0300
From: Eduardo Habkost <ehabkost@redhat.com>
Message-ID: <20150305164835.GF13041@thinpad.lan.raisama.net>
References: <1425569930-6660-1-git-send-email-ehabkost@redhat.com>
	<1425569930-6660-7-git-send-email-ehabkost@redhat.com>
	<20150305174253.41582208@nial.brq.redhat.com>
	<54F8880A.6050908@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <54F8880A.6050908@suse.de>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 6/6] target-i386: Call cpu_exec_init() on
 realize
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>
Cc: zhugh.fnst@cn.fujitsu.com, qemu-devel@nongnu.org, tangchen@cn.fujitsu.com, chen.fan.fnst@cn.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, Paolo Bonzini <pbonzini@redhat.com>, anshul.makkar@profitbricks.com, Gu Zheng <guz.fnst@cn.fujitsu.com>, Igor Mammedov <imammedo@redhat.com>

On Thu, Mar 05, 2015 at 05:44:58PM +0100, Andreas F=E4rber wrote:
> Am 05.03.2015 um 17:42 schrieb Igor Mammedov:
[...]
> >> @@ -2840,7 +2842,6 @@ static void x86_cpu_initfn(Object *obj)
> >>      CPUX86State *env =3D &cpu->env;
> >> =20
> >>      cs->env_ptr =3D env;
> >> -    cpu_exec_init(env);
> > looks wrong, later in this function we do
> >  env->cpuid_apic_id =3D x86_cpu_apic_id_from_index(cs->cpu_index);
> > and with this patch will always yield 0
>=20
> Being tackled in Eduardo's APIC series. ;)

Which is already queued at the x86 tree mentioned in the cover letter,
BTW:
  https://github.com/ehabkost/qemu.git x86

--=20
Eduardo