From: alexandre.belloni@free-electrons.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: at91: remove ksz8081 phy fixup registration for sama5d4ek board
Date: Fri, 6 Mar 2015 00:37:36 +0100 [thread overview]
Message-ID: <20150305233736.GE3989@piout.net> (raw)
In-Reply-To: <20150304113523.GF3989@piout.net>
On 04/03/2015 at 12:35:23 +0100, Alexandre Belloni wrote :
> On 04/03/2015 at 12:20:12 +0100, Boris Brezillon wrote :
> > Commit 2b0ba96cea60 ("net: phy: micrel: disable NAND-tree for KSZ8021,
> > KSZ8031, KSZ8051, KSZ8081") automated the NAND-tree mode deactivation
> > process, thus making this phy fixup useless.
> > Remove it along with the associated headers inclusion.
> >
> > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
>
Actually, as Rob pointed out in my patch series, please remove the
selection of PHYLIB in the Kconfig.
> > ---
> > arch/arm/mach-at91/sama5.c | 20 --------------------
> > 1 file changed, 20 deletions(-)
> >
> > diff --git a/arch/arm/mach-at91/sama5.c b/arch/arm/mach-at91/sama5.c
> > index 03dcb44..23d067a 100644
> > --- a/arch/arm/mach-at91/sama5.c
> > +++ b/arch/arm/mach-at91/sama5.c
> > @@ -11,13 +11,10 @@
> > #include <linux/init.h>
> > #include <linux/module.h>
> > #include <linux/gpio.h>
> > -#include <linux/micrel_phy.h>
> > #include <linux/of.h>
> > #include <linux/of_irq.h>
> > #include <linux/of_platform.h>
> > -#include <linux/phy.h>
> > #include <linux/clk-provider.h>
> > -#include <linux/phy.h>
> >
> > #include <mach/hardware.h>
> >
> > @@ -29,25 +26,8 @@
> >
> > #include "generic.h"
> >
> > -static int ksz8081_phy_fixup(struct phy_device *phy)
> > -{
> > - int value;
> > -
> > - value = phy_read(phy, 0x16);
> > - value &= ~0x20;
> > - phy_write(phy, 0x16, value);
> > -
> > - return 0;
> > -}
> > -
> > static void __init sama5_dt_device_init(void)
> > {
> > - if (of_machine_is_compatible("atmel,sama5d4ek") &&
> > - IS_ENABLED(CONFIG_PHYLIB)) {
> > - phy_register_fixup_for_id("fc028000.etherne:00",
> > - ksz8081_phy_fixup);
> > - }
> > -
> > of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
> > at91sam9x5_pm_init();
> > }
> > --
> > 1.9.1
> >
>
> --
> Alexandre Belloni, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-03-05 23:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-04 11:20 [PATCH] ARM: at91: remove ksz8081 phy fixup registration for sama5d4ek board Boris Brezillon
2015-03-04 11:35 ` Alexandre Belloni
2015-03-05 23:37 ` Alexandre Belloni [this message]
2015-03-06 8:24 ` Nicolas Ferre
2015-03-11 16:34 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150305233736.GE3989@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.