Re: [PATCH v1 1/2] xen/arm: Add Cadence UART driver

["Edgar E. Iglesias" <edgar.iglesias@gmail.com>]

On Thu, Mar 05, 2015 at 05:06:22PM +0000, Ian Campbell wrote:
> On Thu, 2015-03-05 at 18:27 +1000, Edgar E. Iglesias wrote:
> > Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
> > ---
> >  config/arm64.mk                    |   1 +
> >  xen/drivers/char/Makefile          |   1 +
> >  xen/drivers/char/cadence-uart.c    | 222 +++++++++++++++++++++++++++++++++++++
> >  xen/include/asm-arm/cadence-uart.h |  55 +++++++++
> >  4 files changed, 279 insertions(+)
> >  create mode 100644 xen/drivers/char/cadence-uart.c
> >  create mode 100644 xen/include/asm-arm/cadence-uart.h
> 
> I tried to apply this but:
> 
> cadence-uart.c:211:5: error: unknown field 'compatible' specified in initializer
>      .compatible = cuart_dt_compat,
>      ^
> cadence-uart.c:211:5: error: initialization from incompatible pointer type [-Werror]
> cadence-uart.c:211:5: error: (near initialization for '__dev_desc_cuart.dt_match') [-Werror]
> cc1: all warnings being treated as errors
> 
> I think because this patch needs to be rebased onto:
> commit f9eff198f9d4863e80078a33001a9bb90a99a4b1
> Author: Julien Grall <julien.grall@linaro.org>
> Date:   Wed Feb 25 18:52:57 2015 +0000
> 
>     xen/arm: Describe devices supported by a driver with dt_device_match
>     
>     Xen is currently using a list of compatible strings to match drivers again
>     device nodes. This leads to having double definitions in the GIC
>     code.
>     
>     Furthermore Linux drivers are using dt_device_match (actually called
>     of_device_id in Linux) to list device supported by the drivers.
>     
>     Remove the exisiting compatible field and replace with a dt_match field
>     
>     Signed-off-by: Julien Grall <julien.grall@linaro.org>
>     Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>     Acked-by: Ian Campbell <ian.campbell@citrix.com>
> 
> Which is currently in the staging branch (this is the pre automated test
> branch, normally master is fine but sometimes there can be conflicts).
> 
> Please could you rebase and resend.

Thanks Ian,

I've rebased and sending out a v2 now.

Cheers,
Edgar


> 
> Thanks,
> Ian.