From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754656AbbCFIaJ (ORCPT ); Fri, 6 Mar 2015 03:30:09 -0500 Received: from mail.skyhub.de ([78.46.96.112]:40167 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752009AbbCFIaD (ORCPT ); Fri, 6 Mar 2015 03:30:03 -0500 Date: Fri, 6 Mar 2015 09:28:46 +0100 From: Borislav Petkov To: Naoya Horiguchi Cc: "Luck, Tony" , Prarit Bhargava , Vivek Goyal , "linux-kernel@vger.kernel.org" , Junichi Nomura , Kiyoshi Ueda Subject: Re: [PATCH v5] x86: mce: kexec: switch MCE handler for kexec/kdump Message-ID: <20150306082846.GC3514@pd.tnic> References: <1425373306-26187-1-git-send-email-n-horiguchi@ah.jp.nec.com> <3908561D78D1C84285E8C5FCA982C28F329F5837@ORSMSX114.amr.corp.intel.com> <20150304074117.GA30501@hori1.linux.bs1.fc.nec.co.jp> <3908561D78D1C84285E8C5FCA982C28F329F835A@ORSMSX114.amr.corp.intel.com> <20150305012447.GA16001@hori1.linux.bs1.fc.nec.co.jp> <20150305064509.GA16012@hori1.linux.bs1.fc.nec.co.jp> <20150305085735.GE3915@pd.tnic> <20150305093752.GA11764@hori1.linux.bs1.fc.nec.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150305093752.GA11764@hori1.linux.bs1.fc.nec.co.jp> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 05, 2015 at 09:37:52AM +0000, Naoya Horiguchi wrote: > print_mce() doesn't help? No, it doesn't because it does a bunch of MCA-specific things too. > Currently quirk_no_way_out() is set only for a specific CPU model, so even > if we define another callback for kdump code, setting it to a real function > need to be done in MCE internal function, __mcheck_cpu_apply_quirks() ? > > It seems that in this version I relied on reusing exisiting code too much. > So I'll do only what I really need. Then, if the model specific behavior > (what quirk_sandybridge_ifu() does) doesn't affect machine_check_under_kdump()'s > behavior, simply stop copying this part is a right thing to do? Just add this to mce.c in a pre-patch: void mce_mc_callback(void *arg) { if (quirk_no_way_out) quirk_no_way_out(i, m, regs); } I'm still not madly in love with it but I can't think of something better. Maybe Tony would have a better idea... -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --