From: Darren Hart <dvhart@infradead.org>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: wmi: Remove private %pUL implementation
Date: Fri, 6 Mar 2015 09:52:32 -0800 [thread overview]
Message-ID: <20150306175232.GC19001@vmdeb7> (raw)
In-Reply-To: <1424787330-26770-1-git-send-email-linux@rasmusvillemoes.dk>
On Tue, Feb 24, 2015 at 03:15:30PM +0100, Rasmus Villemoes wrote:
> The work performed by wmi_gtoa is equivalent to simply sprintf(out,
> "%pUL", in), so one could replace its body by this. However, most
> users feed the result directly as a %s argument to some other function
> which also understands the %p extensions (they all ultimately use
> vsnprintf), so we can eliminate some stack buffers and quite a bit of
> code by just using %pUL directly.
>
> In wmi_dev_uevent I'm not sure whether there's room for a
> nul-terminator in env->buf, so I've just replaced wmi_gtoa with the
> equivalent sprintf call.
>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Nice cleanup, thanks Rasmus. Queued for 4.1.
--
Darren Hart
Intel Open Source Technology Center
next prev parent reply other threads:[~2015-03-06 17:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-24 14:15 [PATCH] x86: wmi: Remove private %pUL implementation Rasmus Villemoes
2015-03-06 17:52 ` Darren Hart [this message]
2015-05-12 12:06 ` Rasmus Villemoes
2015-09-09 22:08 ` Rasmus Villemoes
2015-09-10 3:34 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150306175232.GC19001@vmdeb7 \
--to=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.