From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Fri, 06 Mar 2015 19:37:11 +0100 (CET) Received: from pmta1.delivery4.ore.mailhop.org ([54.191.151.194]:34012 "EHLO pmta1.delivery4.ore.mailhop.org" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27008279AbbCFShIEiUgF (ORCPT ); Fri, 6 Mar 2015 19:37:08 +0100 Received: from smtp6.ore.mailhop.org (172.31.18.134) by pmta1.delivery1.ore.mailhop.org id hv7ps020r84p; Fri, 6 Mar 2015 18:36:40 +0000 (envelope-from ) Received: from 104.193.169-186.public.monkeybrains.net ([104.193.169.186] helo=atomide.com) by smtp6.ore.mailhop.org with esmtpsa (TLSv1.2:AES128-GCM-SHA256:128) (Exim 4.82) (envelope-from ) id 1YTx7M-00021E-QJ; Fri, 06 Mar 2015 18:37:01 +0000 X-Mail-Handler: DuoCircle Outbound SMTP X-Originating-IP: 104.193.169.186 X-Report-Abuse-To: abuse@duocircle.com (see https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information for abuse reporting information) X-MHO-User: U2FsdGVkX18PfME/Mbp1KmbHYQQ6uL1F Date: Fri, 6 Mar 2015 10:31:38 -0800 From: Tony Lindgren To: Valentin Rothberg Cc: akpm@linux-foundation.org, Jonathan Corbet , Ralf Baechle , David Woodhouse , Brian Norris , Greg Kroah-Hartman , Paul Bolle , Jiri Kosina , Hannes Reinecke , Ewan Milne , Christoph Hellwig , Hongliang Tao , Huacai Chen , Nishanth Menon , Peter Ujfalusi , Santosh Shilimkar , Rajendra Nayak , Afzal Mohammed , Keerthy , Sricharan R , Zhou Wang , Dan Carpenter , Felipe Balbi , Laurent Pinchart , Thomas Gleixner , Quentin Lambert , Arnd Bergmann , Ingo Molnar , Eyal Perry , Peter Zijlstra , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, iss_storagedev@hp.com, linux-mtd@lists.infradead.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v2] Remove deprecated IRQF_DISABLED flag entirely Message-ID: <20150306183137.GZ13520@atomide.com> References: <1425560442-13367-1-git-send-email-valentinrothberg@gmail.com> <1425565425-12604-1-git-send-email-valentinrothberg@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1425565425-12604-1-git-send-email-valentinrothberg@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 46240 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: tony@atomide.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips * Valentin Rothberg [150305 06:24]: > The IRQF_DISABLED is a NOOP and has been scheduled for removal since > Linux v2.6.36 by commit 6932bf37bed4 ("genirq: Remove IRQF_DISABLED from > core code"). > > According to commit e58aa3d2d0cc ("genirq: Run irq handlers with > interrupts disabled") running IRQ handlers with interrupts enabled can > cause stack overflows when the interrupt line of the issuing device is > still active. > > This patch ends the grace period for IRQF_DISABLED (i.e., SA_INTERRUPT > in older versions of Linux) and removes the definition and all remaining > usages of this flag. > > Signed-off-by: Valentin Rothberg Acked-by: Tony Lindgren From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pmta1.delivery4.ore.mailhop.org ([54.191.151.194]) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YTx7j-0004bE-7Q for linux-mtd@lists.infradead.org; Fri, 06 Mar 2015 18:37:23 +0000 Received: from smtp6.ore.mailhop.org (172.31.18.134) by pmta1.delivery1.ore.mailhop.org id hv7psu20r847 for ; Fri, 6 Mar 2015 18:36:40 +0000 (envelope-from ) Date: Fri, 6 Mar 2015 10:31:38 -0800 From: Tony Lindgren To: Valentin Rothberg Subject: Re: [PATCH v2] Remove deprecated IRQF_DISABLED flag entirely Message-ID: <20150306183137.GZ13520@atomide.com> References: <1425560442-13367-1-git-send-email-valentinrothberg@gmail.com> <1425565425-12604-1-git-send-email-valentinrothberg@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1425565425-12604-1-git-send-email-valentinrothberg@gmail.com> Cc: Nishanth Menon , linux-mips@linux-mips.org, Jiri Kosina , Peter Zijlstra , Peter Ujfalusi , Sricharan R , linux-mtd@lists.infradead.org, Felipe Balbi , Huacai Chen , Christoph Hellwig , iss_storagedev@hp.com, Jonathan Corbet , Quentin Lambert , Ewan Milne , Ingo Molnar , Dan Carpenter , Afzal Mohammed , Arnd Bergmann , Rajendra Nayak , Eyal Perry , Hannes Reinecke , Thomas Gleixner , Paul Bolle , Keerthy , linux-usb@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Ralf Baechle , Zhou Wang , Santosh Shilimkar , Greg Kroah-Hartman , Hongliang Tao , akpm@linux-foundation.org, Brian Norris , David Woodhouse , Laurent Pinchart List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , * Valentin Rothberg [150305 06:24]: > The IRQF_DISABLED is a NOOP and has been scheduled for removal since > Linux v2.6.36 by commit 6932bf37bed4 ("genirq: Remove IRQF_DISABLED from > core code"). > > According to commit e58aa3d2d0cc ("genirq: Run irq handlers with > interrupts disabled") running IRQ handlers with interrupts enabled can > cause stack overflows when the interrupt line of the issuing device is > still active. > > This patch ends the grace period for IRQF_DISABLED (i.e., SA_INTERRUPT > in older versions of Linux) and removes the definition and all remaining > usages of this flag. > > Signed-off-by: Valentin Rothberg Acked-by: Tony Lindgren