From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f46.google.com ([209.85.218.46]:37601 "EHLO mail-oi0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752067AbbCFStY (ORCPT ); Fri, 6 Mar 2015 13:49:24 -0500 Received: by oigi138 with SMTP id i138so19193908oig.4 for ; Fri, 06 Mar 2015 10:49:23 -0800 (PST) Date: Fri, 6 Mar 2015 12:49:20 -0600 From: Bjorn Helgaas To: Alex Deucher Cc: Alex Williamson , Linux PCI , Dave Airlie , "Deucher, Alexander" , Maling list - DRI developers , LKML Subject: Re: [PATCH 0/2] PCI: pci_unignore_hotplug() Message-ID: <20150306184920.GI20077@google.com> References: <20150224200603.14443.68971.stgit@gimli.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: linux-pci-owner@vger.kernel.org List-ID: On Tue, Feb 24, 2015 at 03:23:27PM -0500, Alex Deucher wrote: > On Tue, Feb 24, 2015 at 3:12 PM, Alex Williamson > wrote: > > I'd kinda like to use pci_ignore_hotplug() for devices in use by a > > user via vfio-pci, but the interface seems only partially implemented > > since we can only set ignore_hotplug and not clear it. This adds the > > capability to clear the flag and applies it as seems to be appropriate > > to the existing users. I don't have a system with power control for > > a radeon or nouveau device, so I'd certainly appreciate testing. It > > seems though that once the device is in D0, we've passed the critical > > point where the device could be accidentally unplugged. Thanks, > > Something re-broke this recently. See: > https://bugzilla.kernel.org/show_bug.cgi?id=61891 > https://bugzilla.kernel.org/show_bug.cgi?id=89731 I'm not opposed to adding pci_unignore_hotplug() when we have users for it. I don't really want to throw in the nouveau and radeon changes while there are open issues in the same area, though. I haven't looked at the bugzillas above. Let me know if I should. Bjorn From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Helgaas Subject: Re: [PATCH 0/2] PCI: pci_unignore_hotplug() Date: Fri, 6 Mar 2015 12:49:20 -0600 Message-ID: <20150306184920.GI20077@google.com> References: <20150224200603.14443.68971.stgit@gimli.home> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-oi0-f42.google.com (mail-oi0-f42.google.com [209.85.218.42]) by gabe.freedesktop.org (Postfix) with ESMTP id 3FDD66E360 for ; Fri, 6 Mar 2015 10:49:24 -0800 (PST) Received: by oifu20 with SMTP id u20so19166212oif.12 for ; Fri, 06 Mar 2015 10:49:23 -0800 (PST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Alex Deucher Cc: Linux PCI , LKML , Maling list - DRI developers , Alex Williamson , "Deucher, Alexander" List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBGZWIgMjQsIDIwMTUgYXQgMDM6MjM6MjdQTSAtMDUwMCwgQWxleCBEZXVjaGVyIHdy b3RlOgo+IE9uIFR1ZSwgRmViIDI0LCAyMDE1IGF0IDM6MTIgUE0sIEFsZXggV2lsbGlhbXNvbgo+ IDxhbGV4LndpbGxpYW1zb25AcmVkaGF0LmNvbT4gd3JvdGU6Cj4gPiBJJ2Qga2luZGEgbGlrZSB0 byB1c2UgcGNpX2lnbm9yZV9ob3RwbHVnKCkgZm9yIGRldmljZXMgaW4gdXNlIGJ5IGEKPiA+IHVz ZXIgdmlhIHZmaW8tcGNpLCBidXQgdGhlIGludGVyZmFjZSBzZWVtcyBvbmx5IHBhcnRpYWxseSBp bXBsZW1lbnRlZAo+ID4gc2luY2Ugd2UgY2FuIG9ubHkgc2V0IGlnbm9yZV9ob3RwbHVnIGFuZCBu b3QgY2xlYXIgaXQuICBUaGlzIGFkZHMgdGhlCj4gPiBjYXBhYmlsaXR5IHRvIGNsZWFyIHRoZSBm bGFnIGFuZCBhcHBsaWVzIGl0IGFzIHNlZW1zIHRvIGJlIGFwcHJvcHJpYXRlCj4gPiB0byB0aGUg ZXhpc3RpbmcgdXNlcnMuICBJIGRvbid0IGhhdmUgYSBzeXN0ZW0gd2l0aCBwb3dlciBjb250cm9s IGZvcgo+ID4gYSByYWRlb24gb3Igbm91dmVhdSBkZXZpY2UsIHNvIEknZCBjZXJ0YWlubHkgYXBw cmVjaWF0ZSB0ZXN0aW5nLiAgSXQKPiA+IHNlZW1zIHRob3VnaCB0aGF0IG9uY2UgdGhlIGRldmlj ZSBpcyBpbiBEMCwgd2UndmUgcGFzc2VkIHRoZSBjcml0aWNhbAo+ID4gcG9pbnQgd2hlcmUgdGhl IGRldmljZSBjb3VsZCBiZSBhY2NpZGVudGFsbHkgdW5wbHVnZ2VkLiAgVGhhbmtzLAo+IAo+IFNv bWV0aGluZyByZS1icm9rZSB0aGlzIHJlY2VudGx5LiAgU2VlOgo+IGh0dHBzOi8vYnVnemlsbGEu a2VybmVsLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjE4OTEKPiBodHRwczovL2J1Z3ppbGxhLmtlcm5l bC5vcmcvc2hvd19idWcuY2dpP2lkPTg5NzMxCgpJJ20gbm90IG9wcG9zZWQgdG8gYWRkaW5nIHBj aV91bmlnbm9yZV9ob3RwbHVnKCkgd2hlbiB3ZSBoYXZlIHVzZXJzIGZvciBpdC4KSSBkb24ndCBy ZWFsbHkgd2FudCB0byB0aHJvdyBpbiB0aGUgbm91dmVhdSBhbmQgcmFkZW9uIGNoYW5nZXMgd2hp bGUgdGhlcmUKYXJlIG9wZW4gaXNzdWVzIGluIHRoZSBzYW1lIGFyZWEsIHRob3VnaC4KCkkgaGF2 ZW4ndCBsb29rZWQgYXQgdGhlIGJ1Z3ppbGxhcyBhYm92ZS4gIExldCBtZSBrbm93IGlmIEkgc2hv dWxkLgoKQmpvcm4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK