From: Andi Kleen <ak@linux.intel.com>
To: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Cc: David Ahern <dsahern@gmail.com>, Yuanfang Chen <cyfmxc@gmail.com>,
linux-perf-users@vger.kernel.org
Subject: Re: address output in 'perf script' does not work for addr2line
Date: Fri, 6 Mar 2015 15:19:11 -0800 [thread overview]
Message-ID: <20150306231911.GF31334@tassilo.jf.intel.com> (raw)
In-Reply-To: <20150303205026.GN5187@kernel.org>
> > >Yeah, it worked in the past.
> > >commit 5550171b2a9f8df26ff483051d060db06376b26d change ip into
> > >relative address ( not sure relative to which address), which makes
> > >addr2line unable to parse.
>
> > That's Andi's commit.
>
> Oh well, that, IIRC, was done to make the srcline sort key to work, but
> broke the perf script output, so perhaps its time to change the perf
> script output to use that code and show srcline:lineno, will see.
Yes fixing perf script is best. Then the addr2line hacks are not needed
anymore. addr2line was never fully complete, as it couldn't handle
shared libraries.
However we should make it a new key to not break anything existing.
I'll take a look.
-Andi
--
ak@linux.intel.com -- Speaking for myself only
prev parent reply other threads:[~2015-03-06 23:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 16:07 address output in 'perf script' does not work for addr2line Yuanfang Chen
2015-03-03 16:23 ` Arnaldo Carvalho de Melo
2015-03-03 19:27 ` Yuanfang Chen
2015-03-03 19:54 ` David Ahern
2015-03-03 20:50 ` Arnaldo Carvalho de Melo
2015-03-03 21:07 ` Arnaldo Carvalho de Melo
2015-03-06 23:19 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150306231911.GF31334@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=arnaldo.melo@gmail.com \
--cc=cyfmxc@gmail.com \
--cc=dsahern@gmail.com \
--cc=linux-perf-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.