From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757363AbbCGKNq (ORCPT <rfc822;w@1wt.eu>);
	Sat, 7 Mar 2015 05:13:46 -0500
Received: from mail-we0-f177.google.com ([74.125.82.177]:40308 "EHLO
	mail-we0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754157AbbCGKNl (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 7 Mar 2015 05:13:41 -0500
Date: Sat, 7 Mar 2015 11:13:36 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Denys Vlasenko <dvlasenk@redhat.com>,
        "H. Peter Anvin" <hpa@linux.intel.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Steven Rostedt <rostedt@goodmis.org>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>, Oleg Nesterov <oleg@redhat.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Will Drewry <wad@chromium.org>, Kees Cook <keescook@chromium.org>,
        X86 ML <x86@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: clean up unnecessarily wide TEST insns
Message-ID: <20150307101336.GA564@gmail.com>
References: <1425675332-31576-1-git-send-email-dvlasenk@redhat.com>
 <CALCETrXctXAp5hZWCj632hGt_EhXzh0KupD=GFrz7BHWDY80RA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CALCETrXctXAp5hZWCj632hGt_EhXzh0KupD=GFrz7BHWDY80RA@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Andy Lutomirski <luto@amacapital.net> wrote:

> >     +f6 c1 04                   test   $0x4,%cl
> >     -48 f7 c1 08 00 00 00       test   $0x8,%rcx
> >     +f6 c1 08                   test   $0x8,%cl
> >
> >  arch/x86/kernel/head_64.S            |  2 +-
> >  arch/x86/kernel/relocate_kernel_32.S |  8 ++++----
> >  arch/x86/kernel/relocate_kernel_64.S |  8 ++++----
> >  arch/x86/lib/checksum_32.S           |  4 ++--
> >  arch/x86/lib/csum-copy_64.S          |  2 +-
> 
> Looks good to me.  Ingo, should I queue this up?

No need, I picked it up now that the 32-bit crash of tip:x86/asm is 
fixed. I juiced up the changelog a bit. Will push it out after a bit 
of testing.

Thanks,

	Ingo