All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] Fix batctl for static builds
Date: Sat, 7 Mar 2015 13:01:53 +0100	[thread overview]
Message-ID: <20150307130153.3fed78de@free-electrons.com> (raw)
In-Reply-To: <1425672948-1668-1-git-send-email-zettelmeyerj@goooglemail.com>

Dear Jens Zettelmeyer,

On Fri,  6 Mar 2015 20:15:48 +0000, Jens Zettelmeyer wrote:
> Signed-off-by: Jens Zettelmeyer <zettelmeyerj@goooglemail.com>
> ---
>  package/batctl/batctl.mk | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

Thanks for working on this. However, this isn't the right fix for the
problem: batctl uses pkg-config to discover how to link with libnl.
It's just that the libnl .pc files were not correct in terms of static
linking handling. Fixing those .pc files is a better solution, as it 1/
can be upstreamed to libnl, 2/ avoids hacks in batctl.mk, and 3/ allows
to also removes hacks in other Buildroot packages.

See the series I have sent at
http://lists.busybox.net/pipermail/buildroot/2015-March/121180.html.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-03-07 12:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-06 20:15 [Buildroot] [PATCH 1/1] Fix batctl for static builds Jens Zettelmeyer
2015-03-07 12:01 ` Thomas Petazzoni [this message]
2015-03-07 12:27   ` Jens Zettelmeyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150307130153.3fed78de@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.