All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] uclibc: adapt thread implementation selection to uClibc-ng
Date: Sat, 7 Mar 2015 17:41:04 +0100	[thread overview]
Message-ID: <20150307174104.6cefa362@free-electrons.com> (raw)
In-Reply-To: <20150307143411.GC4186@free.fr>

Dear Yann E. MORIN,

On Sat, 7 Mar 2015 15:34:11 +0100, Yann E. MORIN wrote:

> >  	config BR2_UCLIBC_NG_VERSION_1_0_0
> >  		bool "uClibc-ng 1.0.0"
> > +		select BR2_UCLIBC_VERSION_SUPPORTS_LINUXTHREADS \
> > +		       if BR2_arc || BR2_m68k
> > +		select BR2_UCLIBC_VERSION_SUPPORTS_LINUXTHREADS_OLD \
> > +		       if BR2_arc || BR2_bfin || BR2_m68k
> > +		select BR2_UCLIBC_VERSION_SUPPORTS_NPTL \
> > +		       if !BR2_arc && !BR2_bfin && !BR2_x86_i386
> 
> I will trust you on these combinations. ;-)

Well, I was actually looking for some review on those combinations. In
short:

 * There should not be any change for uClibc itself (0.9.33, special
   ARC and Xtensa version, snapshot)

 * For uClibc-ng, the change should be that NPTL becomes the only
   available option, unless you're on ARC, Blackfin or i386 (and by
   i386, I really mean only i386: NPTL on >= i486 is fine).

> Please be consistent: either put the 'select' before or after the
> 'depends' as you prefer, but do it consistently across all options. ;-)
> 
> I tend to prefer depends before select, as it seems more logical to me,
> but I don't mind either, as long as it is consistent.

Sure, I'll fix that up. But I'd prefer to have a review on the
combinations.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-03-07 16:41 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-07 13:39 [Buildroot] [PATCH 0/3] uClibc-ng related fixes Thomas Petazzoni
2015-03-07 13:39 ` [Buildroot] [PATCH 1/3] uclibc: adapt thread implementation selection to uClibc-ng Thomas Petazzoni
2015-03-07 14:34   ` Yann E. MORIN
2015-03-07 16:41     ` Thomas Petazzoni [this message]
2015-03-07 17:20   ` Waldemar Brodkorb
2015-03-08  7:41     ` Thomas Petazzoni
2015-03-09  8:27       ` Alexey Brodkin
2015-03-09  9:46         ` Thomas Petazzoni
2015-03-07 17:39   ` Yann E. MORIN
2015-03-08  7:40     ` Thomas Petazzoni
2015-03-08  8:45       ` Yann E. MORIN
2015-03-08  9:13         ` Waldemar Brodkorb
2015-03-07 13:39 ` [Buildroot] [PATCH 2/3] uclibc: remove bogus comment about thread implementation selection Thomas Petazzoni
2015-03-07 14:34   ` Yann E. MORIN
2015-03-07 13:40 ` [Buildroot] [PATCH 3/3] uclibc: add patch fixing non-threaded build on Xtensa for uClibc-ng 1.0.0 Thomas Petazzoni
2015-03-07 14:40   ` Yann E. MORIN
2015-03-07 15:43     ` Waldemar Brodkorb
2015-03-07 15:50       ` Yann E. MORIN
2015-03-07 16:30       ` Thomas Petazzoni
2015-03-07 17:56         ` Waldemar Brodkorb
2015-03-08  7:35           ` Thomas Petazzoni
2015-03-07 16:29     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150307174104.6cefa362@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.