From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752737AbbCGUvi (ORCPT ); Sat, 7 Mar 2015 15:51:38 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:52554 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752023AbbCGUvg (ORCPT ); Sat, 7 Mar 2015 15:51:36 -0500 Date: Sat, 7 Mar 2015 20:51:32 +0000 From: Al Viro To: Alexander Holler Cc: Alan Stern , Richard Weinberger , USB list , LKML , Felipe Balbi Subject: Re: gadgetfs broken since 7f7f25e8 Message-ID: <20150307205132.GD29656@ZenIV.linux.org.uk> References: <54FADFC2.1030302@ahsoftware.de> <54FB59A7.2080705@ahsoftware.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54FB59A7.2080705@ahsoftware.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 07, 2015 at 09:03:51PM +0100, Alexander Holler wrote: > Am 07.03.2015 um 12:23 schrieb Alexander Holler: > > Am 04.03.2015 um 16:31 schrieb Alan Stern: > > > >> check to see what those values actually were. It's easy enough to fix > >> up, though; revised patch below. > > > > Thanks, in contrast to the patch from Al Viro that one applies. Translation: it applies to mainline as well as to vfs.git#gadget + ep_config_operations patch it's incremental to. > And as I've just tested it, it isn't complete. ep_config_operations will > be switched to ep_io_operations and suffers under the same problem of > not having initially (aio_)read/(aio_)write since commit 7f7f25e8 (3.16). Incremental patch does not deal with the problem handled by the patch it is incremental to, film at 11... FWIW, patches in vfs.git#gadget are fixing fairly obvious bugs - leaks and use-after-free.