From: "Michael S. Tsirkin" <mst@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Markus Armbruster <armbru@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PULL v5] pci, pc, virtio fixes and cleanups
Date: Sun, 8 Mar 2015 11:45:22 +0100 [thread overview]
Message-ID: <20150308104522.GA9080@redhat.com> (raw)
In-Reply-To: <CAFEAcA89B8vOSZT2dejvQc4HjcqKwfGLhsH4zBbRFq4pAA8fag@mail.gmail.com>
On Sun, Mar 08, 2015 at 09:15:41AM +0900, Peter Maydell wrote:
> On 8 March 2015 at 03:17, Michael S. Tsirkin <mst@redhat.com> wrote:
> > OK Markus now confirmed this wasn't (necessarily) triggered
> > by these patches. So nothing should block this pull request now?
>
> Fails to build with clang:
>
> /home/petmay01/linaro/qemu-for-merges/hw/i386/acpi-build.c:471:20:
> error: unused function 'acpi_get_hex' [-Werror,-Wunused-function]
> static inline char acpi_get_hex(uint32_t val)
> ^
> 1 error generated.
>
> -- PMM
I can drop this one as a work around but I wonder why is clang warning
about unused static inlines.
We have a ton of these in each header and it doesn't warn,
in theory static inline should be same as macro: harmless
unless used.
Any idea?
--
MST
next prev parent reply other threads:[~2015-03-08 10:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-04 15:10 [Qemu-devel] [PULL v5] pci, pc, virtio fixes and cleanups Michael S. Tsirkin
2015-03-06 14:27 ` Markus Armbruster
2015-03-06 14:37 ` Peter Maydell
2015-03-06 14:46 ` Markus Armbruster
2015-03-07 17:51 ` Michael S. Tsirkin
2015-03-07 18:17 ` Michael S. Tsirkin
2015-03-08 0:15 ` Peter Maydell
2015-03-08 10:45 ` Michael S. Tsirkin [this message]
2015-03-08 12:26 ` Peter Maydell
2015-03-08 12:41 ` Michael S. Tsirkin
2015-03-06 15:02 ` Igor Mammedov
2015-03-06 16:15 ` Markus Armbruster
2015-03-07 18:00 ` Michael S. Tsirkin
2015-03-07 17:49 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150308104522.GA9080@redhat.com \
--to=mst@redhat.com \
--cc=armbru@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.