From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sudip Mukherjee Date: Sun, 08 Mar 2015 12:59:14 +0000 Subject: Re: [PATCH 1/4] staging: sm750fb: wrong type for print Message-Id: <20150308125859.GA14649@sudip-PC> List-Id: References: <1425817886-14387-1-git-send-email-sudipm.mukherjee@gmail.com> <54FC4323.3010909@gmail.com> In-Reply-To: <54FC4323.3010909@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1254" Content-Transfer-Encoding: base64 To: Giedrius =?utf-8?Q?Statkevi=C4=8Dius?= Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org T24gU3VuLCBNYXIgMDgsIDIwMTUgYXQgMDI6NDA6MDNQTSArMDIwMCwgR2llZHJpdXMgU3RhdGtl dmnEjWl1cyB3cm90ZToKPiBPbiAyMDE1LjAzLjA4IDE0OjMxLCBTdWRpcCBNdWtoZXJqZWUgd3Jv dGU6Cj4gPiBtZW50aW9uIGNvcnJlY3QgZm9ybWF0IHNwZWNpZmllciB3aGlsZSBwcmludGluZwo+ ID4gaW5kZXggNzExNjc2Yy4uMmFiN2I3NCAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvc3RhZ2lu Zy9zbTc1MGZiL3NtNzUwLmgKPiA+ICsrKyBiL2RyaXZlcnMvc3RhZ2luZy9zbTc1MGZiL3NtNzUw LmgKPiA+IEBAIC01OSwxMCArNTksMTAgQEAgc3RydWN0IGx5bnhfc2hhcmV7Cj4gPiAgCQl9bXRy cjsKPiA+ICAjZW5kaWYKPiA+ICAJLyogYWxsIHNtaSBncmFwaGljIGFkYXB0b3IgZ290IGJlbG93 IGF0dHJpYnV0ZXMgKi8KPiA+IC0JcmVzb3VyY2Vfc2l6ZV90IHZpZG1lbV9zdGFydDsKPiA+IC0J cmVzb3VyY2Vfc2l6ZV90IHZpZHJlZ19zdGFydDsKPiA+IC0JcmVzb3VyY2Vfc2l6ZV90IHZpZG1l bV9zaXplOwo+ID4gLQlyZXNvdXJjZV9zaXplX3QgdmlkcmVnX3NpemU7Cj4gPiArCXVuc2lnbmVk IGxvbmcgdmlkbWVtX3N0YXJ0Owo+ID4gKwl1bnNpZ25lZCBsb25nIHZpZHJlZ19zdGFydDsKPiA+ ICsJdW5zaWduZWQgbG9uZyB2aWRtZW1fc2l6ZTsKPiA+ICsJdW5zaWduZWQgbG9uZyB2aWRyZWdf c2l6ZTsKPiAKPiBIYXZlIHlvdSBjaGVja2VkIG90aGVyIHBsYWNlcyB3aGVyZSB0aGVzZSBhcmUg dXNlZD8gcmVzb3VyY2Vfc2l6ZV90IGNhbgo+IGJlIGVpdGhlciB1NjQgb3IgdTMyIGRlcGVuZGlu ZyBvbiBpZiBDT05GSUdfUEhZU19BRERSX1RfNjRCSVQgaXMKPiAjZGVmaW5lZC4gQXJlIHlvdSBz dXJlIHlvdSBhcmVuJ3QgbG9zaW5nIGluZm9ybWF0aW9uIHdoZW4gcmVzdWx0cyBvZgo+IGZ1bmN0 aW9ucyBhcmUgYmVpbmcgYXNzaWduZWQgdG8gdGhpcz8gTWF5YmUgdGhlcmUgc2hvdWxkIGJlIGEg ZnVuY3Rpb24KPiBzaW1pbGFyIHRvIHByaW50ayB0aGF0IGNoYW5nZXMgYmV0d2VlbiAldSBhbmQg JWxsdSBkZXBlbmRpbmcgb24gd2hldGhlcgo+IHRoYXQgaXMgZGVmaW5lZD8KCm9vcHMgLi4gbm8g Li4gOigKaSBjaGVja2VkIGluIG90aGVyIGZyYW1lYnVmZmVyIGRyaXZlcnMgYW5kIHNhdyB0aGV5 IGFyZSBtb3N0bHkgdW5zaWduZWQgbG9uZy4KSSB3aWxsIGNoZWNrIGZ1cnRoZXIgb24gdGhpcy4K CkdyZWc6IGNhbiB5b3UgcGxlYXNlIGRyb3AgdGhpcyBwYXRjaCAoMS80KSBmcm9tIHlvdXIgcXVl dWUgYW5kIG5vdCBhcHBseSB0aGlzIHRvIHlvdXIgdHJlZS4KSSB3aWxsIHNlbmQgaXQgYXMgYSB2 Mi4KCnJlZ2FyZHMKc3VkaXAKCj4gCj4gLS0gCj4gVGhhbmtzLAo+IEdpZWRyaXVzCi0tClRvIHVu c3Vic2NyaWJlIGZyb20gdGhpcyBsaXN0OiBzZW5kIHRoZSBsaW5lICJ1bnN1YnNjcmliZSBsaW51 eC1mYmRldiIgaW4KdGhlIGJvZHkgb2YgYSBtZXNzYWdlIHRvIG1ham9yZG9tb0B2Z2VyLmtlcm5l bC5vcmcKTW9yZSBtYWpvcmRvbW8gaW5mbyBhdCAgaHR0cDovL3ZnZXIua2VybmVsLm9yZy9tYWpv cmRvbW8taW5mby5odG1s From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752671AbbCHM7O (ORCPT ); Sun, 8 Mar 2015 08:59:14 -0400 Received: from mail-pd0-f178.google.com ([209.85.192.178]:36039 "EHLO mail-pd0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752458AbbCHM7K (ORCPT ); Sun, 8 Mar 2015 08:59:10 -0400 Date: Sun, 8 Mar 2015 18:28:59 +0530 From: Sudip Mukherjee To: Giedrius =?utf-8?Q?Statkevi=C4=8Dius?= Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] staging: sm750fb: wrong type for print Message-ID: <20150308125859.GA14649@sudip-PC> References: <1425817886-14387-1-git-send-email-sudipm.mukherjee@gmail.com> <54FC4323.3010909@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <54FC4323.3010909@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 08, 2015 at 02:40:03PM +0200, Giedrius Statkevičius wrote: > On 2015.03.08 14:31, Sudip Mukherjee wrote: > > mention correct format specifier while printing > > index 711676c..2ab7b74 100644 > > --- a/drivers/staging/sm750fb/sm750.h > > +++ b/drivers/staging/sm750fb/sm750.h > > @@ -59,10 +59,10 @@ struct lynx_share{ > > }mtrr; > > #endif > > /* all smi graphic adaptor got below attributes */ > > - resource_size_t vidmem_start; > > - resource_size_t vidreg_start; > > - resource_size_t vidmem_size; > > - resource_size_t vidreg_size; > > + unsigned long vidmem_start; > > + unsigned long vidreg_start; > > + unsigned long vidmem_size; > > + unsigned long vidreg_size; > > Have you checked other places where these are used? resource_size_t can > be either u64 or u32 depending on if CONFIG_PHYS_ADDR_T_64BIT is > #defined. Are you sure you aren't losing information when results of > functions are being assigned to this? Maybe there should be a function > similar to printk that changes between %u and %llu depending on whether > that is defined? oops .. no .. :( i checked in other framebuffer drivers and saw they are mostly unsigned long. I will check further on this. Greg: can you please drop this patch (1/4) from your queue and not apply this to your tree. I will send it as a v2. regards sudip > > -- > Thanks, > Giedrius