From: Mike Krinkin <krinkin.m.u@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Larry.Finger@lwfinger.net, gregkh@linuxfoundation.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: rtl8188eu: use %pM specifier instead of passing direct values
Date: Sun, 8 Mar 2015 20:18:18 +0300 [thread overview]
Message-ID: <20150308171818.GA3766@kmu-tp-x230> (raw)
In-Reply-To: <1425834052.5898.1.camel@perches.com>
On Sun, Mar 08, 2015 at 10:00:52AM -0700, Joe Perches wrote:
> On Sun, 2015-03-08 at 19:42 +0300, Mike Krinkin wrote:
> > The patch converts code to use %pM specifier instead of pushing
> > each byte via stack.
>
> Hello Mike.
>
> > diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c
> []
> > @@ -1096,10 +1096,8 @@ static void Hal_EfuseParseMACAddr_8188EU(struct adapter *adapt, u8 *hwinfo, bool
> > memcpy(eeprom->mac_addr, &hwinfo[EEPROM_MAC_ADDR_88EU], ETH_ALEN);
> > }
> > RT_TRACE(_module_hci_hal_init_c_, _drv_notice_,
> > - ("Hal_EfuseParseMACAddr_8188EU: Permanent Address = %02x-%02x-%02x-%02x-%02x-%02x\n",
> > - eeprom->mac_addr[0], eeprom->mac_addr[1],
> > - eeprom->mac_addr[2], eeprom->mac_addr[3],
> > - eeprom->mac_addr[4], eeprom->mac_addr[5]));
> > + ("Hal_EfuseParseMACAddr_8188EU: Permanent Address = %6phD\n",
> > + eeprom->mac_addr));
>
> You changed the subject and commit log but not
> the patch. V3?
>
It was stupid fault... Sorry for noise.
>
prev parent reply other threads:[~2015-03-08 17:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-08 16:42 [PATCH v2] staging: rtl8188eu: use %pM specifier instead of passing direct values Mike Krinkin
2015-03-08 17:00 ` Joe Perches
2015-03-08 17:18 ` Mike Krinkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150308171818.GA3766@kmu-tp-x230 \
--to=krinkin.m.u@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.