From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932180AbbCHRit (ORCPT ); Sun, 8 Mar 2015 13:38:49 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:54833 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753080AbbCHRio (ORCPT ); Sun, 8 Mar 2015 13:38:44 -0400 Date: Sun, 8 Mar 2015 17:38:37 +0000 From: Al Viro To: Alan Stern Cc: Alexander Holler , Richard Weinberger , USB list , LKML , Felipe Balbi Subject: Re: gadgetfs broken since 7f7f25e8 Message-ID: <20150308173836.GH29656@ZenIV.linux.org.uk> References: <54FB59A7.2080705@ahsoftware.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 07, 2015 at 04:08:49PM -0500, Alan Stern wrote: > On Sat, 7 Mar 2015, Alexander Holler wrote: > > > Am 07.03.2015 um 12:23 schrieb Alexander Holler: > > > Am 04.03.2015 um 16:31 schrieb Alan Stern: > > > > > >> check to see what those values actually were. It's easy enough to fix > > >> up, though; revised patch below. > > > > > > Thanks, in contrast to the patch from Al Viro that one applies. > > > > And as I've just tested it, it isn't complete. ep_config_operations will > > be switched to ep_io_operations and suffers under the same problem of > > not having initially (aio_)read/(aio_)write since commit 7f7f25e8 (3.16). > > Of course. I stated in the email accompanying the original version of > this patch that it contained some corrections that Al's patch left out. > You have to use the two of them together to fix all the issues. FWIW, I've pushed those two fixes in vfs.git#gadget; could I have your s-o-b on the ep0 part? See 2b13438 in vfs.git...