All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Guido Martínez" <guido@vanguardiasur.com.ar>
To: buildroot@busybox.net
Subject: [Buildroot] [RFC/PATCH] linux: remove the zImage before rebuild
Date: Sun, 8 Mar 2015 15:53:09 -0300	[thread overview]
Message-ID: <20150308185309.GA7162@fox> (raw)
In-Reply-To: <20150308184730.5b821dfa@free-electrons.com>

Hi Thomas!

On Sun, Mar 08, 2015 at 06:47:30PM +0100, Thomas Petazzoni wrote:
> Dear Guido Mart?nez,
> 
> On Fri, 26 Sep 2014 20:22:54 -0300, Guido Mart?nez wrote:
> > Currently, if we run "make linux-rebuild", the device tree blob gets
> > appended twice to the kernel image, rendering the latter append useless.
> > 
> > Fix this by removing the zImage before building, so the DTB append runs
> > on a fresh kernel image. This is not optimal as the final Linux linking
> > step is run again, but at least we get sensible results.
> > 
> > Signed-off-by: Guido Mart?nez <guido@vanguardiasur.com.ar>
> 
> First of all, sorry for the slow response. I could indeed reproduce the
> problem.
No problem at all.

> However, I am not entirely happy with the solution you proposed. I'd
> prefer to fix the real problem: the fact that we are overwriting the
> kernel zImage file.
Yes, I don't like that either.

> I believe we should rather concatenate zImage and the DTB into a file
> named maybe zImage.appended-dtb or something like that, and install
> this file to $(BINARIES_DIR) and $(TARGET_DIR)/boot/ (if requested).
I had done exacly this a while ago, but never finished it since some
configurations failed to build (I don't remeber why exactly).

> Or, another possibility is to name the file zImage.<name-of-dtb>, which
> would later on allow to generate multiple zImage with various appended
> DTBs.
This sounds better! In fact a feature to append different DTBs to the
image would be useful for myself.

> Doing this however requires reworking quite a bit the
> LINUX_IMAGE_NAME / LINUX_TARGET_NAME logic. Would you be willing to
> work on something like this?
Yes, give me a while and I'll try to send a patch.

Cheers!

-- 
Guido Mart?nez, VanguardiaSur
www.vanguardiasur.com.ar

  reply	other threads:[~2015-03-08 18:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-26 23:22 [Buildroot] [RFC/PATCH] linux: remove the zImage before rebuild Guido Martínez
2014-10-22 14:40 ` Guido Martínez
2015-03-08 17:47 ` Thomas Petazzoni
2015-03-08 18:53   ` Guido Martínez [this message]
2015-07-17 16:01 ` Hollis Blanchard
2015-07-17 16:34   ` Guido Martínez
2015-07-17 17:41     ` Thomas Petazzoni
2015-07-17 18:49       ` Hollis Blanchard
2015-07-17 21:16         ` Thomas Petazzoni
2015-07-17 21:24           ` Hollis Blanchard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150308185309.GA7162@fox \
    --to=guido@vanguardiasur.com.ar \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.