From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: libxl__device_nextid and holes Date: Mon, 9 Mar 2015 08:58:38 +0100 Message-ID: <20150309075830.GA13482@aepfle.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org I wonder if libxl__device_nextid is robust enough to handle holes. If there are 3 devices (0,1,2) of type X, and device #0 or #1 is removed with "X-detach", wouldn't the code return nextid==2? The result would be that the caller will write to the wrong path. I have not veified this theory in practice. Olaf