From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Mon, 09 Mar 2015 09:22:09 +0000 Subject: Re: [PATCH 1/4] staging: sm750fb: wrong type for print Message-Id: <20150309092209.GB10964@mwanda> List-Id: References: <1425817886-14387-1-git-send-email-sudipm.mukherjee@gmail.com> In-Reply-To: <1425817886-14387-1-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sudip Mukherjee Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org On Sun, Mar 08, 2015 at 06:01:23PM +0530, Sudip Mukherjee wrote: > diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h > index 711676c..2ab7b74 100644 > --- a/drivers/staging/sm750fb/sm750.h > +++ b/drivers/staging/sm750fb/sm750.h > @@ -59,10 +59,10 @@ struct lynx_share{ > }mtrr; > #endif > /* all smi graphic adaptor got below attributes */ > - resource_size_t vidmem_start; > - resource_size_t vidreg_start; > - resource_size_t vidmem_size; > - resource_size_t vidreg_size; > + unsigned long vidmem_start; > + unsigned long vidreg_start; > + unsigned long vidmem_size; > + unsigned long vidreg_size; > volatile unsigned char __iomem * pvReg; > unsigned char __iomem * pvMem; > /* locks*/ This seems like a very risky sort of change. It's not explained very well in the changelog. What's the deal? regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753682AbbCIJW3 (ORCPT ); Mon, 9 Mar 2015 05:22:29 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:26907 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753323AbbCIJW1 (ORCPT ); Mon, 9 Mar 2015 05:22:27 -0400 Date: Mon, 9 Mar 2015 12:22:09 +0300 From: Dan Carpenter To: Sudip Mukherjee Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] staging: sm750fb: wrong type for print Message-ID: <20150309092209.GB10964@mwanda> References: <1425817886-14387-1-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1425817886-14387-1-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 08, 2015 at 06:01:23PM +0530, Sudip Mukherjee wrote: > diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h > index 711676c..2ab7b74 100644 > --- a/drivers/staging/sm750fb/sm750.h > +++ b/drivers/staging/sm750fb/sm750.h > @@ -59,10 +59,10 @@ struct lynx_share{ > }mtrr; > #endif > /* all smi graphic adaptor got below attributes */ > - resource_size_t vidmem_start; > - resource_size_t vidreg_start; > - resource_size_t vidmem_size; > - resource_size_t vidreg_size; > + unsigned long vidmem_start; > + unsigned long vidreg_start; > + unsigned long vidmem_size; > + unsigned long vidreg_size; > volatile unsigned char __iomem * pvReg; > unsigned char __iomem * pvMem; > /* locks*/ This seems like a very risky sort of change. It's not explained very well in the changelog. What's the deal? regards, dan carpenter