All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Aring <alex.aring@gmail.com>
To: linux-wpan@vger.kernel.org
Cc: kernel@pengutronix.de, mkl@pengutronix.de
Subject: Re: [RFC bluetooth-next 1/2] of: net: add support for extended address
Date: Mon, 9 Mar 2015 10:33:13 +0100	[thread overview]
Message-ID: <20150309093312.GA711@omega> (raw)
In-Reply-To: <1425802643-5798-2-git-send-email-alex.aring@gmail.com>

Hi,

some notes from me which I figured out for reviewing right now.

On Sun, Mar 08, 2015 at 09:17:22AM +0100, Alexander Aring wrote:
...
> +}
> +EXPORT_SYMBOL(of_get_extended_address);
> diff --git a/include/linux/of_net.h b/include/linux/of_net.h
> index 34597c8..6e677ab 100644
> --- a/include/linux/of_net.h
> +++ b/include/linux/of_net.h
> @@ -11,6 +11,7 @@
>  #include <linux/of.h>
>  extern int of_get_phy_mode(struct device_node *np);
>  extern const void *of_get_mac_address(struct device_node *np);
> +extern __le64 of_get_extended_address(struct device_node *np);
>  #else
>  static inline int of_get_phy_mode(struct device_node *np)
>  {
> @@ -21,6 +22,11 @@ static inline const void *of_get_mac_address(struct device_node *np)
>  {
>  	return NULL;
>  }
> +
> +static inline __le64 of_get_extended_address(struct device_node *np)
> +{
> +	return cpu_to_le64(0x0000000000000000ULL);
> +}
>  #endif
>  

I need to be sure that __le64 is definied here from include of
<linux/of.h>. I didn't check that right now.

- Alex

  reply	other threads:[~2015-03-09  9:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-08  8:17 [RFC bluetooth-next 0/2] ieee802154: add usual way to get extended address via device tree Alexander Aring
2015-03-08  8:17 ` [RFC bluetooth-next 1/2] of: net: add support for extended address Alexander Aring
2015-03-09  9:33   ` Alexander Aring [this message]
2015-03-08  8:17 ` [RFC bluetooth-next 2/2] at86rf230: add support for dt or pdata extended addr Alexander Aring
2015-03-09  9:36   ` Alexander Aring
2015-03-09  9:39     ` Alexander Aring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150309093312.GA711@omega \
    --to=alex.aring@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-wpan@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.