Re: [Outreachy kernel] [PATCH v3 1/2] Staging: rtl8188eu: Eliminate use of _set_timer

[Greg KH <gregkh@linuxfoundation.org>]

On Sat, Mar 07, 2015 at 01:21:37PM +0530, Vaishali Thakkar wrote:
> This patch introduces the use of API function mod_timer
> instead of driver specific function _set_timer as it is
> a more efficient and standard way to update the expire
> field of an active timer. Also, definition of function
> _set_timer is removed as it is no longer needed after
> this change.
> 
> Here, these cases are handled using Coccinelle and
> semantic patch used for this is as follows:
> 
> @@ expression x; expression y;@@
> 
> - _set_timer (&x, y);
> + mod_timer (&x, jiffies + msecs_to_jiffies (y));
> 
> Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
> ---
> v1 : Here, this patch has some line over 80 characters as
>      limiting them to 80 characters does not make code look
>      good and readable.
> v2 : Change commit log
>    - Redo the patch against staging-testing
> v3 : No change but as patch is in series with another patch,
>      sending this as a new version.

You obviously didn't even test-build this patch, otherwise you wouldn't
have submitted it :(

Hint, _ALWAYS_ test build patches, to break the build is not allowed at
all.

thanks,

greg k-h