From: Greg KH <gregkh@linuxfoundation.org>
To: Somya Anand <somyaanand214@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH v3 3/3] Staging: rtl8188eu: Remove redundant local variable
Date: Mon, 9 Mar 2015 13:20:02 +0100 [thread overview]
Message-ID: <20150309122002.GA20677@kroah.com> (raw)
In-Reply-To: <1425751228-9804-3-git-send-email-somyaanand214@gmail.com>
On Sat, Mar 07, 2015 at 11:30:28PM +0530, Somya Anand wrote:
> This patch removes a redundant variable "val" and adds
> inline return statements. It also adds a default case
> to the switch statement which returns 0 to keep the logic
> intact.
>
> It also removes a redundant variable "inx" and adds inline
> return statements.
>
> This issue is identified by the following coccinelle script.
> @@
> expression ret;
> identifier f;
> @@
>
> -ret =
> +return
> f(...);
> -return ret;
>
> Signed-off-by: Somya Anand <somyaanand214@gmail.com>
> ---
> drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 82 +++++++++-----------------
This patch also does not apply :(
Please refresh your patches against my latest staging-testing branch of
staging.git on git.kernel.org and resend them.
thanks,
greg k-h
next prev parent reply other threads:[~2015-03-09 12:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-07 18:00 [PATCH v3 1/3] Staging: rtl8188eu: Remove unneeded return statement Somya Anand
2015-03-07 18:00 ` [PATCH v3 2/3] staging: rtl8188eu: Remove unneeded parentheses Somya Anand
2015-03-07 18:00 ` [PATCH v3 3/3] Staging: rtl8188eu: Remove redundant local variable Somya Anand
2015-03-09 12:20 ` Greg KH [this message]
2015-03-09 12:19 ` [Outreachy kernel] [PATCH v3 1/3] Staging: rtl8188eu: Remove unneeded return statement Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150309122002.GA20677@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=somyaanand214@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.