From: Antoine Tenart <antoine.tenart@free-electrons.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Antoine Tenart <antoine.tenart@free-electrons.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] phy: berlin-sata: Use devm_kcalloc at appropriate place
Date: Mon, 9 Mar 2015 14:02:46 +0100 [thread overview]
Message-ID: <20150309130246.GA8421@kwain> (raw)
In-Reply-To: <1425519641.1637.2.camel@phoenix>
On Thu, Mar 05, 2015 at 09:40:41AM +0800, Axel Lin wrote:
> Prefer devm_kcalloc over devm_kzalloc with multiply.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Antoine Tenart <antoine.tenart@free-electrons.com>
> ---
> drivers/phy/phy-berlin-sata.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/phy-berlin-sata.c b/drivers/phy/phy-berlin-sata.c
> index 099eee8..6f3e06d 100644
> --- a/drivers/phy/phy-berlin-sata.c
> +++ b/drivers/phy/phy-berlin-sata.c
> @@ -218,7 +218,7 @@ static int phy_berlin_sata_probe(struct platform_device *pdev)
> if (priv->nphys == 0)
> return -ENODEV;
>
> - priv->phys = devm_kzalloc(dev, priv->nphys * sizeof(*priv->phys),
> + priv->phys = devm_kcalloc(dev, priv->nphys, sizeof(*priv->phys),
> GFP_KERNEL);
> if (!priv->phys)
> return -ENOMEM;
> --
> 1.9.1
>
>
>
--
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2015-03-09 13:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-05 1:40 [PATCH] phy: berlin-sata: Use devm_kcalloc at appropriate place Axel Lin
2015-03-09 13:02 ` Antoine Tenart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150309130246.GA8421@kwain \
--to=antoine.tenart@free-electrons.com \
--cc=axel.lin@ingics.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.