From: Andi Kleen <ak@linux.intel.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Andi Kleen <andi@firstfloor.org>,
acme@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] perf, tools: Output running time and run/enabled ratio in CSV mode
Date: Mon, 9 Mar 2015 07:04:34 -0700 [thread overview]
Message-ID: <20150309140434.GG31334@tassilo.jf.intel.com> (raw)
In-Reply-To: <20150309074954.GA27885@krava.brq.redhat.com>
> hum, so people using CSV mode will now see extra 2 numbers
> at the end of the line:
>
> $ ./perf.old stat -x, -e cycles ls > /dev/null
> 2679161,,cycles
> $ ./perf stat -x, -e cycles ls > /dev/null
> 2574169,,cycles,1295544,100.00
>
> we could be breaking existing scripts..
I doubt it. Typical CSV parsers ignore additional data at the end.
Just don't insert stuff in the middle (like it was done recently).
That breaks a lot of things.
> you recently added 'running-time' option for record,
> could you please add same option for stat?
Could be done, but I'm not sure it's worth it here.
-Andi
next prev parent reply other threads:[~2015-03-09 14:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-08 23:55 A number of perf stat improvements Andi Kleen
2015-03-08 23:55 ` [PATCH 1/4] perf, tools: Output running time and run/enabled ratio in CSV mode Andi Kleen
2015-03-09 7:49 ` Jiri Olsa
2015-03-09 14:04 ` Andi Kleen [this message]
2015-03-10 7:15 ` Namhyung Kim
2015-03-10 15:37 ` Andi Kleen
2015-03-11 0:52 ` Namhyung Kim
2015-03-08 23:55 ` [PATCH 2/4] perf, tools: Fix metrics calculation with event qualifiers Andi Kleen
2015-03-09 7:55 ` Jiri Olsa
2015-03-08 23:55 ` [PATCH 3/4] perf, tools, stat: Fix IPC and other formulas with -A Andi Kleen
2015-03-09 8:11 ` Jiri Olsa
2015-03-08 23:55 ` [PATCH 4/4] perf, tools, stat: Always correctly indent ratio column Andi Kleen
2015-03-09 8:24 ` Jiri Olsa
2015-03-11 13:35 ` A number of perf stat improvements Arnaldo Carvalho de Melo
2015-03-11 15:29 ` Andi Kleen
2015-03-11 19:13 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150309140434.GG31334@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=acme@kernel.org \
--cc=andi@firstfloor.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.