From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752533AbbCIP2a (ORCPT <rfc822;w@1wt.eu>);
	Mon, 9 Mar 2015 11:28:30 -0400
Received: from mail-wi0-f176.google.com ([209.85.212.176]:40803 "EHLO
	mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752256AbbCIP21 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 9 Mar 2015 11:28:27 -0400
Date: Mon, 9 Mar 2015 16:28:22 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Denys Vlasenko <vda.linux@googlemail.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>,
        Andy Lutomirski <luto@amacapital.net>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Steven Rostedt <rostedt@goodmis.org>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>, Oleg Nesterov <oleg@redhat.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Alexei Starovoitov <ast@plumgrid.com>, Will Drewry <wad@chromium.org>,
        Kees Cook <keescook@chromium.org>, X86 ML <x86@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] move offsetofend() from vfio.h to stddef.h
Message-ID: <20150309152822.GA21219@gmail.com>
References: <1425912738-559-1-git-send-email-dvlasenk@redhat.com>
 <20150309145844.GA19511@gmail.com>
 <CAK1hOcN2zvZGhPxRRcoQCv=i-kEOhN2o_gofaRAj+hnFE8uLqg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAK1hOcN2zvZGhPxRRcoQCv=i-kEOhN2o_gofaRAj+hnFE8uLqg@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Denys Vlasenko <vda.linux@googlemail.com> wrote:

> On Mon, Mar 9, 2015 at 3:58 PM, Ingo Molnar <mingo@kernel.org> wrote:
> >> -/**
> >> - * offsetofend(TYPE, MEMBER)
> >> - *
> >> - * @TYPE: The type of the structure
> >> - * @MEMBER: The member within the structure to get the end offset of
> >> - *
> >> - * Simple helper macro for dealing with variable sized structures passed
> >> - * from user space.  This allows us to easily determine if the provided
> >> - * structure is sized to include various fields.
> >> - */
> >> -#define offsetofend(TYPE, MEMBER) \
> >> -     (offsetof(TYPE, MEMBER) + sizeof(((TYPE *)0)->MEMBER))
> >
> > So I like it, and because it is not particularly trivial when to use
> > this primitive it was explained nicely in a description in the vfio.h
> > version.
> >
> > But you lost that nice description during the code move!!
> 
> That description was clearly specific to how that macro is used in
> drivers/vfio/*.c, along the lines of
> 
>                 minsz = offsetofend(struct vfio_eeh_pe_op, op);

Hm, but here 'minsz' == sizeof(struct vfio_eeh_pe_op), so the vfio 
usage does not seem to be justified.

>                 if (copy_from_user(&op, (void __user *)arg, minsz))
>                         return -EFAULT;
>                 if (op.argsz < minsz || op.flags)
>                         return -EINVAL;
> 
> But the macro is generic, it has many other uses besides this one.

So I might be missing something, but what generic uses does it have, 
beyond structures that have some rare size related weirdness, such as 
alignment attributes? In 99% of the cases:

   sizeof(struct) == offsetofend(struct, last_member)

right?

> Nevertheless, I can resend a version where comment survives if you 
> want...

So maybe extend it to a description that you think describes its uses 
correctly? People will keep wondering about when to use this.

Thanks,

	Ingo