From: Felipe Balbi <balbi@ti.com>
To: Vinod Koul <vinod.koul@intel.com>
Cc: Felipe Balbi <balbi@ti.com>,
dmaengine@vger.kernel.org,
Linux USB Mailing List <linux-usb@vger.kernel.org>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
Dan Williams <dan.j.williams@intel.com>
Subject: Re: [PATCH] dma: cppi41: add missing directions bitfield
Date: Mon, 9 Mar 2015 10:50:20 -0500 [thread overview]
Message-ID: <20150309155020.GD3739@saruman.tx.rr.com> (raw)
In-Reply-To: <20150304124323.GR2613@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1106 bytes --]
On Wed, Mar 04, 2015 at 06:13:23PM +0530, Vinod Koul wrote:
> On Wed, Feb 25, 2015 at 04:54:02PM -0600, Felipe Balbi wrote:
> > Without those we will see a kernel WARN()
> > when loading musb on am335x devices.
> >
> > Signed-off-by: Felipe Balbi <balbi@ti.com>
> > ---
> > drivers/dma/cppi41.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/dma/cppi41.c b/drivers/dma/cppi41.c
> > index 512cb8e2805e..4e9cc8e8100c 100644
> > --- a/drivers/dma/cppi41.c
> > +++ b/drivers/dma/cppi41.c
> > @@ -926,6 +926,7 @@ static int cppi41_dma_probe(struct platform_device *pdev)
> > cdd->ddev.device_issue_pending = cppi41_dma_issue_pending;
> > cdd->ddev.device_prep_slave_sg = cppi41_dma_prep_slave_sg;
> > cdd->ddev.device_terminate_all = cppi41_stop_chan;
> > + cdd->ddev.directions = BIT(DMA_DEV_TO_MEM) | BIT(DMA_MEM_TO_DEV);
> > cdd->ddev.dev = dev;
> > INIT_LIST_HEAD(&cdd->ddev.channels);
> > cpp41_dma_info.dma_cap = cdd->ddev.cap_mask;
> Along with this please set src/dstn_addr_widths and residue_granularity
> please
will do.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2015-03-09 15:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 22:54 [PATCH] dma: cppi41: add missing directions bitfield Felipe Balbi
2015-03-04 12:43 ` Vinod Koul
2015-03-09 15:50 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150309155020.GD3739@saruman.tx.rr.com \
--to=balbi@ti.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.